[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [ark] /: clazy: fix some unneeded qstring allocations
From:       Elvis Angelaccio <elvis.angelaccio () kdemail ! net>
Date:       2015-12-31 15:44:41
Message-ID: E1aEfP7-00012Y-HQ () scm ! kde ! org
[Download RAW message or body]

Git commit d3bdf4c16684f94f787cb1a2bd0d6a887387853b by Elvis Angelaccio.
Committed on 31/12/2015 at 15:03.
Pushed by elvisangelaccio into branch 'master'.

clazy: fix some unneeded qstring allocations

M  +1    -1    kerfuffle/queries.cpp
M  +1    -1    part/arkviewer.cpp

http://commits.kde.org/ark/d3bdf4c16684f94f787cb1a2bd0d6a887387853b

diff --git a/kerfuffle/queries.cpp b/kerfuffle/queries.cpp
index 4c6171d..1455552 100644
--- a/kerfuffle/queries.cpp
+++ b/kerfuffle/queries.cpp
@@ -177,7 +177,7 @@ void PasswordNeededQuery::execute()
 
     QPointer<KPasswordDialog> dlg = new KPasswordDialog;
     dlg.data()->setPrompt(xi18nc("@info", "The archive <filename>%1</filename> is \
                password protected. Please enter the password to extract the file.",
-                                 m_data.value(QLatin1String( "archiveFilename" \
)).toString())); +                                 \
m_data.value(QStringLiteral("archiveFilename")).toString()));  
     if (m_data.value(QStringLiteral("incorrectTryAgain")).toBool()) {
         dlg.data()->showErrorMessage(i18n("Incorrect password, please try again."), \
                KPasswordDialog::PasswordError);
diff --git a/part/arkviewer.cpp b/part/arkviewer.cpp
index 6b207a1..61489ea 100644
--- a/part/arkviewer.cpp
+++ b/part/arkviewer.cpp
@@ -258,7 +258,7 @@ KService::Ptr ArkViewer::getViewer(const QString &mimeType)
     }
 
     // Try to get a read-only kpart for the internal viewer
-    KService::List offers = KMimeTypeTrader::self()->query(mimeType, \
QString::fromLatin1("KParts/ReadOnlyPart")); +    KService::List offers = \
KMimeTypeTrader::self()->query(mimeType, QStringLiteral("KParts/ReadOnlyPart"));  
     // If we can't find a kpart, try to get an external application
     if (offers.isEmpty()) {


[prev in list] [next in list] [prev in thread] [next in thread]