[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [akonadi-next/develop] common: Cleanup
From:       Christian Mollekopf <chrigi_1 () fastmail ! fm>
Date:       2015-12-31 14:10:10
Message-ID: E1aEdve-0006v3-Fg () scm ! kde ! org
[Download RAW message or body]

Git commit 91bef9cfa52fcba6eed618436510fb63a8facfc6 by Christian Mollekopf.
Committed on 31/12/2015 at 14:08.
Pushed by cmollekopf into branch 'develop'.

Cleanup

M  +2    -12   common/domainadaptor.h

http://commits.kde.org/akonadi-next/91bef9cfa52fcba6eed618436510fb63a8facfc6

diff --git a/common/domainadaptor.h b/common/domainadaptor.h
index b541e23..39bd3b8 100644
--- a/common/domainadaptor.h
+++ b/common/domainadaptor.h
@@ -82,8 +82,6 @@ static void createBufferPartBuffer(const Akonadi2::Applic=
ationDomain::Applicatio
 =

 /**
  * A generic adaptor implementation that uses a property mapper to read/wr=
ite values.
- * =

- * TODO: this is the read-only part. Create a write only equivalent
  */
 template <class LocalBuffer, class ResourceBuffer>
 class GenericBufferAdaptor : public Akonadi2::ApplicationDomain::BufferAda=
ptor
@@ -95,11 +93,6 @@ public:
 =

     }
 =

-    //TODO remove
-    void setProperty(const QByteArray &key, const QVariant &value)
-    {
-    }
-
     virtual QVariant getProperty(const QByteArray &key) const
     {
         if (mResourceBuffer && mResourceMapper->hasMapping(key)) {
@@ -107,16 +100,13 @@ public:
         } else if (mLocalBuffer && mLocalMapper->hasMapping(key)) {
             return mLocalMapper->getProperty(key, mLocalBuffer);
         }
-        qWarning() << "no mapping available for key " << key;
+        Warning() << "No mapping available for key " << key;
         return QVariant();
     }
 =

     virtual QList<QByteArray> availableProperties() const
     {
-        QList<QByteArray> props;
-        props << mResourceMapper->availableProperties();
-        props << mLocalMapper->availableProperties();
-        return props;
+        return mResourceMapper->availableProperties() + mLocalMapper->avai=
lableProperties();
     }
 =

     LocalBuffer const *mLocalBuffer;

[prev in list] [next in list] [prev in thread] [next in thread]