[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [plasma-workspace] applets/mediacontroller/contents/ui: [Media Controller] Drop album art placeholde
From:       Kai Uwe Broulik <kde () privat ! broulik ! de>
Date:       2015-12-29 0:22:12
Message-ID: E1aDi3I-00045Y-8A () scm ! kde ! org
[Download RAW message or body]

Git commit 8fd4459a49d3e4ff4b6985a503f1649c5e0dd8c9 by Kai Uwe Broulik.
Committed on 29/12/2015 at 00:20.
Pushed by broulik into branch 'master'.

[Media Controller] Drop album art placeholder

It serves no real purpose and was using the wrong icon anyway.

M  +5    -10   applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

http://commits.kde.org/plasma-workspace/8fd4459a49d3e4ff4b6985a503f1649c5e0dd8c9

diff --git a/applets/mediacontroller/contents/ui/ExpandedRepresentation.qml \
b/applets/mediacontroller/contents/ui/ExpandedRepresentation.qml index \
                ffd7844..8dfa08b 100644
--- a/applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
+++ b/applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
@@ -59,15 +59,16 @@ Item {
         }
     }
 
-    Column {
+    ColumnLayout {
         id: titleColumn
         width: constrained ? parent.width - units.largeSpacing : parent.width
         spacing: units.smallSpacing
 
         RowLayout {
             id: titleRow
+            Layout.fillWidth: true
+            Layout.minimumHeight: expandedRepresentation.height / 2
             spacing: units.largeSpacing
-            width: parent.width
 
             Image {
                 id: albumArt
@@ -75,13 +76,7 @@ Item {
                 fillMode: Image.PreserveAspectCrop
                 Layout.preferredHeight: expandedRepresentation.height / 2
                 Layout.preferredWidth: Layout.preferredHeight
-                visible: !!root.track
-
-                PlasmaCore.IconItem {
-                    anchors.fill: parent
-                    source: "tools-rip-audio-cd" // FIXME VDG Needs a proper album \
                art cover dummy
-                    visible: parent.status !== Image.Ready
-                }
+                visible: !!root.track && status === Image.Ready
             }
 
             ColumnLayout {
@@ -117,7 +112,7 @@ Item {
 
         PlasmaComponents.Slider {
             id: seekSlider
-            width: parent.width
+            Layout.fillWidth: true
             z: 999
             maximumValue: currentMetadata ? currentMetadata["mpris:length"] || 0 : 0
             value: 0


[prev in list] [next in list] [prev in thread] [next in thread]