Git commit d7252750721e19267c798481705ac1dd64e021c5 by Tomaz Canabrava. Committed on 30/11/2015 at 23:22. Pushed by tcanabrava into branch 'master'. if / else if misusage. Signed-off-by: Tomaz Canabrava M +7 -5 brprint3d.cpp http://commits.kde.org/brprint3d/d7252750721e19267c798481705ac1dd64e021c5 diff --git a/brprint3d.cpp b/brprint3d.cpp index db1e959..b81114c 100755 --- a/brprint3d.cpp +++ b/brprint3d.cpp @@ -156,7 +156,11 @@ void BrPrint3D::hidePrinterSettings() } } = -void BrPrint3D::changeIcon(bool checked){ +void BrPrint3D::changeIcon(bool checked) +{ + //TODO: Remove this method - Icon handling should be on the BigButton = class, not here. + // Since you are using 'onClick' to mark if a widget is checked, consi= der using a QToolButton + // instead of a QPush button and let the button manage the OnClicked /= OnChecked automatically. if( sender() =3D=3D bt_play ) { if (checked){ QIcon icon(":/Icons/Icons/playOnClick.png"); @@ -167,15 +171,13 @@ void BrPrint3D::changeIcon(bool checked){ bt_play->setIcon(QIcon(":/Icons/Icons/play.png")); bt_play->setChecked(false); } - } - if (sender()=3D=3Dbt_pause) { + } else if (sender()=3D=3Dbt_pause) { if (checked) { bt_pause->setIcon(QIcon(":/Icons/Icons/pauseOnClick.png")); } else { bt_pause->setIcon(QIcon(":/Icons/Icons/pause.png")); } - } - if (sender()=3D=3Dbt_connect) { + } else if (sender()=3D=3Dbt_connect) { if (checked) { bt_connect->setIcon(QIcon(":/Icons/Icons/connectOnClick.png")); } else {