[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [attica] src: Remove superflous breaks
From:       Vishesh Handa <me () vhanda ! in>
Date:       2015-11-24 11:23:58
Message-ID: E1a1BhW-0004iE-MC () scm ! kde ! org
[Download RAW message or body]

Git commit f321581b5d4f424d814c366ab8d4e8c2800523fc by Vishesh Handa.
Committed on 24/11/2015 at 11:23.
Pushed by vhanda into branch 'master'.

Remove superflous breaks

Found via clang -Wunreachable-code-break

M  +0    -7    src/achievement.cpp
M  +0    -4    src/comment.cpp

http://commits.kde.org/attica/f321581b5d4f424d814c366ab8d4e8c2800523fc

diff --git a/src/achievement.cpp b/src/achievement.cpp
index 95dc10c..8bef887 100644
--- a/src/achievement.cpp
+++ b/src/achievement.cpp
@@ -46,16 +46,12 @@ QString Achievement::achievementTypeToString(const Achi=
evement::Type type)
     switch (type) {
     case Achievement::FlowingAchievement:
         return QLatin1String("flowing");
-        break;
     case Achievement::SteppedAchievement:
         return QLatin1String("stepped");
-        break;
     case Achievement::NamedstepsAchievement:
         return QLatin1String("namedsteps");
-        break;
     case Achievement::SetAchievement:
         return QLatin1String("set");
-        break;
     }
 =

     Q_ASSERT(false);
@@ -81,13 +77,10 @@ QString Achievement::achievementVisibilityToString(cons=
t Achievement::Visibility
     switch (visibility) {
     case Achievement::VisibleAchievement:
         return QLatin1String("visible");
-        break;
     case Achievement::DependentsAchievement:
         return QLatin1String("dependents");
-        break;
     case Achievement::SecretAchievement:
         return QLatin1String("secret");
-        break;
     }
 =

     Q_ASSERT(false);
diff --git a/src/comment.cpp b/src/comment.cpp
index f04f2ac..647fcda 100644
--- a/src/comment.cpp
+++ b/src/comment.cpp
@@ -33,16 +33,12 @@ QString Comment::commentTypeToString(const Comment::Typ=
e type)
     switch (type) {
     case ContentComment:
         return QLatin1String("1");
-        break;
     case ForumComment:
         return QLatin1String("4");
-        break;
     case KnowledgeBaseComment:
         return QLatin1String("7");
-        break;
     case EventComment:
         return QLatin1String("8");
-        break;
     }
 =

     Q_ASSERT(false);
[prev in list] [next in list] [prev in thread] [next in thread]