[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    extragear/utils/kpager
From:       Pino Toscano <pino () kde ! org>
Date:       2015-11-19 8:36:31
Message-ID: E1ZzKhj-0007kI-Ih () scm ! kde ! org
[Download RAW message or body]

SVN commit 1444579 by pino:

optimize removals from QHash

instead of lookup (value() or operator[]) + remove(), use take() to do
both at once


 M  +2 -4      kpager.cpp  


--- trunk/extragear/utils/kpager/kpager.cpp #1444578:1444579
@@ -454,10 +454,9 @@
 
 void KPager::slotWindowRemoved( WId win )
 {
-    KWindowInfo* inf = m_windows.value(win);
+    KWindowInfo* inf = m_windows.take(win);
     if (inf)
     {
-        m_windows.remove( win );
         m_windowPixmapsCache.remove(win);
         updateDesktop(inf->desktop());
         delete inf;
@@ -482,8 +481,7 @@
 
     if (prop)
     {
-      delete m_windows[win];
-      m_windows.remove( win );
+      delete m_windows.take(win);
       inf = info( win );
     }
 
[prev in list] [next in list] [prev in thread] [next in thread]