[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    extragear/utils/kpager
From:       Pino Toscano <pino () kde ! org>
Date:       2015-11-19 7:44:39
Message-ID: E1ZzJtX-0005Wn-Dp () scm ! kde ! org
[Download RAW message or body]

SVN commit 1444575 by pino:

rename redrawDesktops() to updateAllDesktops(), and use it all around

give it a better name, and make use of it instead of doing the same job
(not much, arguably) in different places


 M  +1 -1      desktop.cpp  
 M  +5 -13     kpager.cpp  
 M  +1 -1      kpager.h  


--- trunk/extragear/utils/kpager/desktop.cpp #1444574:1444575
@@ -646,7 +646,7 @@
     m_bgPixmap=0L;
 
 
-    if (m_isCommon) pager()->redrawDesktops();
+    if (m_isCommon) pager()->updateAllDesktops();
     else update();
   } else kDebug() << "Error getting the background\n";
 }
--- trunk/extragear/utils/kpager/kpager.cpp #1444574:1444575
@@ -395,8 +395,7 @@
     Settings::self()->findItem(lHeight())->setProperty(nHg);
 
     updateLayout();
-    foreach (Desktop *desk, m_desktops)
-        desk->update();
+    updateAllDesktops();
 }
 
 KWindowInfo* KPager::info( WId win )
@@ -433,9 +432,7 @@
     // if either the previous or the current active window was on all desktops,
     // update all of them
     if ((desk1 == NET::OnAllDesktops) || (desk2 == NET::OnAllDesktops)) {
-        foreach (Desktop *d, m_desktops) {
-            d->update();
-        }
+        updateAllDesktops();
     } else {
         if (desk1 > 0) {
             m_desktops.at(desk1 - 1)->update();
@@ -508,10 +505,7 @@
 void KPager::slotStackingOrderChanged()
 {
     m_desktops[m_currentDesktop-1]->m_grabWindows=true;
-    foreach (Desktop *d, m_desktops)
-    {
-        d->update();
-    }
+    updateAllDesktops();
 //    update(true);
 }
 
@@ -671,7 +665,7 @@
     }
 }
 
-void KPager::redrawDesktops()
+void KPager::updateAllDesktops()
 {
     foreach (Desktop *d, m_desktops)
         d->update();
@@ -703,9 +697,7 @@
 void KPager::updateDesktop(int desk)
 {
     if (desk == NET::OnAllDesktops) {
-        foreach (Desktop *d, m_desktops) {
-            d->update();
-        }
+        updateAllDesktops();
     } else if (desk > 0) {
         m_desktops.at(desk - 1)->update();
     }
--- trunk/extragear/utils/kpager/kpager.h #1444574:1444575
@@ -77,7 +77,7 @@
 
     void updateLayout();
 
-    void redrawDesktops();
+    void updateAllDesktops();
     void updateDesktop(int desk);
 
     void showPopupMenu(WId wid, const QPoint &pos);
[prev in list] [next in list] [prev in thread] [next in thread]