[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kdevelop/5.0] languages/clang/duchain: Only add the Incomplete flag for Unknown TU environments
From:       Olivier JG <olivier.jg () gmail ! com>
Date:       2015-11-03 20:45:08
Message-ID: E1ZtiS4-0005XI-5K () scm ! kde ! org
[Download RAW message or body]

Git commit 558d212d269c7d4afdf72a8e6034e3301d416cbd by Olivier JG.
Committed on 03/11/2015 at 20:49.
Pushed by olivierjg into branch '5.0'.

Only add the Incomplete flag for Unknown TU environments

See discussion about this flag at:
http://lists.llvm.org/pipermail/cfe-dev/2015-November/045806.html

M  +4    -2    languages/clang/duchain/parsesession.cpp

http://commits.kde.org/kdevelop/558d212d269c7d4afdf72a8e6034e3301d416cbd

diff --git a/languages/clang/duchain/parsesession.cpp b/languages/clang/duchain/parsesession.cpp
index c6f5df7..652b04b 100644
--- a/languages/clang/duchain/parsesession.cpp
+++ b/languages/clang/duchain/parsesession.cpp
@@ -123,8 +123,10 @@ ParseSessionData::ParseSessionData(const QVector<UnsavedFile>& unsavedFiles, Cla
         flags |= CXTranslationUnit_ForSerialization;
     } else {
         flags |= CXTranslationUnit_CacheCompletionResults
-              |  CXTranslationUnit_PrecompiledPreamble
-              |  CXTranslationUnit_Incomplete;
+              |  CXTranslationUnit_PrecompiledPreamble;
+        if (environment.quality() == ClangParsingEnvironment::Unknown) {
+            flags |= CXTranslationUnit_Incomplete;
+        }
     }
 
     const auto tuUrl = environment.translationUnitUrl();
[prev in list] [next in list] [prev in thread] [next in thread]