[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kio] src/filewidgets: Connect to the signals of QDialogButtonBox, not QDialog
From:       Frank Reininghaus <frank78ac () googlemail ! com>
Date:       2015-09-20 7:39:08
Message-ID: CAFoZWWj9WFikA-yS-EObpnm+4Wq3Ur0sM+O+ZeKXciMiERZnwQ () mail ! gmail ! com
[Download RAW message or body]

Hi David,

2015-09-20 0:31 GMT+02:00 David Faure <faure@kde.org>:
> Did you intend to commit all this debug output?
>
> On Wednesday 16 September 2015 21:01:43 Frank Reininghaus wrote:
>> Git commit 689fd43ae226ad026dd2fb6e198a5fef40c24b13 by Frank Reininghaus.
>> Committed on 16/09/2015 at 21:01.
>> Pushed by freininghaus into branch 'master'.
>>
>> Connect to the signals of QDialogButtonBox, not QDialog

oops. No, I didn't. I had added this debug output locally to the to
understand if the functions get called at all, and then only added the
two lines with the fix with "git add -p". Later, I amended the commit
to add the REVIEW number to the commit message, and I probably  added
the "-a" option accidentally and ran "git commit --amend -a", which
then added the debug output.

I'll fix that in a minute. Sorry for the trouble and thanks for spotting this!

Have a nice Sunday,
Frank
[prev in list] [next in list] [prev in thread] [next in thread]