[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kdepim/Applications/15.08] libksieve/ksieveui: Fix memory leak and crash in ManageSieveScriptsD
From:       laurent Montel <montel () kde ! org>
Date:       2015-09-15 11:26:31
Message-ID: 1897059.7lJzN5HRcL () linux-19td
[Download RAW message or body]

Hi,
This patch is incorrect in this branch :)
We don't have private class
=> it will not compile for sur :)
Could you fix it please ?
thanks

Le mardi 15 septembre 2015, 11:20:03 CEST Dan Vrátil a écrit :
> Git commit 9c1a1d87503d4e12990b93dcab63941c7e91ab8f by Dan Vrátil.
> Committed on 15/09/2015 at 11:19.
> Pushed by dvratil into branch 'Applications/15.08'.
> 
> Fix memory leak and crash in ManageSieveScriptsDialog
> 
> M  +3    -0    libksieve/ksieveui/managesievescriptsdialog.cpp
> 
> http://commits.kde.org/kdepim/9c1a1d87503d4e12990b93dcab63941c7e91ab8f
> 
> diff --git a/libksieve/ksieveui/managesievescriptsdialog.cpp
> b/libksieve/ksieveui/managesievescriptsdialog.cpp index e6e5acc..8e2f413
> 100644
> --- a/libksieve/ksieveui/managesievescriptsdialog.cpp
> +++ b/libksieve/ksieveui/managesievescriptsdialog.cpp
> @@ -152,6 +152,9 @@ ManageSieveScriptsDialog::~ManageSieveScriptsDialog()
>  {
>      KConfigGroup group(KSharedConfig::openConfig(),
> "ManageSieveScriptsDialog"); group.writeEntry("Size", size());
> +    // prevent QTreeWidget signals triggered by it's desctructor from
> calling our slots +    d->mTreeView->disconnect(this);
> +    delete d;
>  }
> 
>  void ManageSieveScriptsDialog::hideEvent(QHideEvent *event)

-- 
Laurent Montel | laurent.montel@kdab.com | KDE/Qt Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company
Tel. France +33 (0)4 90 84 08 53,  http://www.kdab.fr


[prev in list] [next in list] [prev in thread] [next in thread]