[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [calligra] plan/libs/ui: Const ref for parameters where possible
From:       Friedrich W. H. Kossebau <kossebau () kde ! org>
Date:       2015-08-31 23:03:06
Message-ID: E1ZWY6U-0007Xp-ML () scm ! kde ! org
[Download RAW message or body]

Git commit 108d42ae180fc892e8e9f88393186ee13d35c8fa by Friedrich W. H. Kossebau.
Committed on 31/08/2015 at 22:47.
Pushed by kossebau into branch 'master'.

Const ref for parameters where possible

M  +1    -1    plan/libs/ui/kptdependencyeditor.cpp
M  +1    -1    plan/libs/ui/kptdependencyeditor.h
M  +1    -1    plan/libs/ui/kptrelationeditor.cpp
M  +1    -1    plan/libs/ui/kptrelationeditor.h
M  +1    -1    plan/libs/ui/kpttaskeditor.cpp
M  +1    -1    plan/libs/ui/kpttaskeditor.h

http://commits.kde.org/calligra/108d42ae180fc892e8e9f88393186ee13d35c8fa

diff --git a/plan/libs/ui/kptdependencyeditor.cpp \
b/plan/libs/ui/kptdependencyeditor.cpp index 8511e64..28f701b 100644
--- a/plan/libs/ui/kptdependencyeditor.cpp
+++ b/plan/libs/ui/kptdependencyeditor.cpp
@@ -2385,7 +2385,7 @@ void DependencyEditor::slotAddSubMilestone()
     m_currentnode = 0;
 }
 
-void DependencyEditor::edit( QModelIndex i )
+void DependencyEditor::edit( const QModelIndex &i )
 {
     if ( i.isValid() ) {
 /*        QModelIndex p = m_view->itemModel()->parent( i );
diff --git a/plan/libs/ui/kptdependencyeditor.h b/plan/libs/ui/kptdependencyeditor.h
index a017461..48137ef 100644
--- a/plan/libs/ui/kptdependencyeditor.h
+++ b/plan/libs/ui/kptdependencyeditor.h
@@ -566,7 +566,7 @@ private Q_SLOTS:
     void slotDeleteTask();
 
 private:
-    void edit( QModelIndex index );
+    void edit( const QModelIndex &index );
 
 private:
     DependencyView *m_view;
diff --git a/plan/libs/ui/kptrelationeditor.cpp b/plan/libs/ui/kptrelationeditor.cpp
index d9d5dd4..9154038 100644
--- a/plan/libs/ui/kptrelationeditor.cpp
+++ b/plan/libs/ui/kptrelationeditor.cpp
@@ -190,7 +190,7 @@ void RelationEditor::slotAddRelation()
     kDebug(planDbg());
 }
 
-void RelationEditor::edit( QModelIndex i )
+void RelationEditor::edit( const QModelIndex &i )
 {
     if ( i.isValid() ) {
 //        QModelIndex p = m_view->model()->parent( i );
diff --git a/plan/libs/ui/kptrelationeditor.h b/plan/libs/ui/kptrelationeditor.h
index 01a3ff5..09b6d54 100644
--- a/plan/libs/ui/kptrelationeditor.h
+++ b/plan/libs/ui/kptrelationeditor.h
@@ -111,7 +111,7 @@ private Q_SLOTS:
     void slotHeaderContextMenuRequested( const QPoint& );
     
 private:
-    void edit( QModelIndex index );
+    void edit( const QModelIndex &index );
 
 private:
     RelationTreeView *m_view;
diff --git a/plan/libs/ui/kpttaskeditor.cpp b/plan/libs/ui/kpttaskeditor.cpp
index bd5b3ba..4e3df89 100644
--- a/plan/libs/ui/kpttaskeditor.cpp
+++ b/plan/libs/ui/kpttaskeditor.cpp
@@ -863,7 +863,7 @@ void TaskEditor::slotAddSubtask()
     edit( idx );
 }
 
-void TaskEditor::edit( QModelIndex i )
+void TaskEditor::edit( const QModelIndex &i )
 {
     if ( i.isValid() ) {
         m_view->selectionModel()->setCurrentIndex( i, QItemSelectionModel::Rows | \
                QItemSelectionModel::ClearAndSelect );
diff --git a/plan/libs/ui/kpttaskeditor.h b/plan/libs/ui/kpttaskeditor.h
index 9a35f8a..b293018 100644
--- a/plan/libs/ui/kpttaskeditor.h
+++ b/plan/libs/ui/kpttaskeditor.h
@@ -182,7 +182,7 @@ private Q_SLOTS:
     void slotProjectShown( bool );
 
 private:
-    void edit( QModelIndex index );
+    void edit( const QModelIndex &index );
 
 private:
     TaskEditorTreeView *m_view;


[prev in list] [next in list] [prev in thread] [next in thread]