[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [calligra/frameworks] /: Clean up code ending with ";;" (silent)
From:       Inge Wallin <inge () lysator ! liu ! se>
Date:       2015-04-13 10:55:02
Message-ID: 5061650.8cpG1q7f4H () linux-iixz ! site
[Download RAW message or body]

On Sunday, April 12, 2015 22:48:20 Jaroslaw Staniek wrote:
> Git commit d152d6e483d4a84d8a6e197e07142b6d2130237a by Jaroslaw Staniek.
> Committed on 12/04/2015 at 22:46.
> Pushed by staniek into branch 'frameworks'.
> 
> Clean up code ending with ";;"

Hi Jaroslaw,

This patch is probably good, but it's not so good that it's done in the 
frameworks branch.

All changes in 2.9 are merged into master, and all changes in master are 
merged into frameworks.  So if you do the change in frameworks directly, this 
means that the difference between it and the other branches will increase and 
future merging be made more difficult. 

This patch alone is probably not going to cause any big problems, but if this 
continues, then the unnecessary differences will accumulate and at some point 
it will be painful.

I suggest that you do this type of clean up patches in 2.9 but others may 
disagree and prefer master.  I think frameworks is the worst choice, though.

[prev in list] [next in list] [prev in thread] [next in thread]