[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kdevplatform] /: Do not report subversion as being not found when it actually was
From:       Kevin Funk <kfunk () kde ! org>
Date:       2015-04-07 7:34:00
Message-ID: 1897169.3xt75SKV6K () kerberos
[Download RAW message or body]


On Saturday, April 04, 2015 06:41:17 PM Andreas Pakulat wrote:
> Git commit 205bd46a5e61f04ebbbb7d218cced7dde8987318 by Andreas Pakulat.
> Committed on 04/04/2015 at 18:41.
> Pushed by apaku into branch 'master'.
> 
> Do not report subversion as being not found when it actually was
> 
> The feature summary requires a _FOUND variable that is named exactly as
> the package that is being looked up. In this case KDevelop uses
> SubversionLibrary but the variable it set was SUBVERSION_FOUND. Hence
> feature_summary thought the package was not found and reported that even
> if all subversion libraries/includes have been solved.
> 
> M  +13   -14   cmake/modules/FindSubversionLibrary.cmake
> M  +1    -1    plugins/CMakeLists.txt
> 
> http://commits.kde.org/kdevplatform/205bd46a5e61f04ebbbb7d218cced7dde8987318
> 
> (snip)

Could you backport to 1.7 branch?

Cheers

-- 
Kevin Funk | kfunk@kde.org | http://kfunk.org
["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]