[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kdepim/KDE/4.14] mailcommon/filter: Add more unittest
From:       Montel Laurent <montel () kde ! org>
Date:       2015-03-23 6:43:56
Message-ID: E1YZw5c-0005ak-Br () scm ! kde ! org
[Download RAW message or body]

Git commit 01106556fdf456815365c76561f4787964a06f17 by Montel Laurent.
Committed on 23/03/2015 at 06:43.
Pushed by mlaurent into branch 'KDE/4.14'.

Add more unittest

M  +14   -0    mailcommon/filter/autotests/filteractionsetstatustest.cpp
M  +3    -0    mailcommon/filter/autotests/filteractionsetstatustest.h
M  +1    -0    mailcommon/filter/filteractions/filteractionwithstringlist.cpp

http://commits.kde.org/kdepim/01106556fdf456815365c76561f4787964a06f17

diff --git a/mailcommon/filter/autotests/filteractionsetstatustest.cpp \
b/mailcommon/filter/autotests/filteractionsetstatustest.cpp index efaa6b6..4ebf5f3 \
                100644
--- a/mailcommon/filter/autotests/filteractionsetstatustest.cpp
+++ b/mailcommon/filter/autotests/filteractionsetstatustest.cpp
@@ -17,6 +17,7 @@
 
 #include "filteractionsetstatustest.h"
 #include "../filteractions/filteractionsetstatus.h"
+#include <QWidget>
 #include <qtest_kde.h>
 
 FilterActionSetStatusTest::FilterActionSetStatusTest(QObject *parent)
@@ -30,4 +31,17 @@ FilterActionSetStatusTest::~FilterActionSetStatusTest()
 
 }
 
+void FilterActionSetStatusTest::shouldHaveDefaultValue()
+{
+    MailCommon::FilterActionSetStatus filter;
+    QWidget *w = filter.createParamWidget(0);
+    QCOMPARE(w->objectName(), QLatin1String("combobox"));
+}
+
+void FilterActionSetStatusTest::shouldHaveSieveRequires()
+{
+    MailCommon::FilterActionSetStatus filter;
+    QCOMPARE(filter.sieveRequires(), QStringList() << QLatin1String("imap4flags"));
+}
+
 QTEST_KDEMAIN(FilterActionSetStatusTest, GUI)
diff --git a/mailcommon/filter/autotests/filteractionsetstatustest.h \
b/mailcommon/filter/autotests/filteractionsetstatustest.h index c28842e..53d2e63 \
                100644
--- a/mailcommon/filter/autotests/filteractionsetstatustest.h
+++ b/mailcommon/filter/autotests/filteractionsetstatustest.h
@@ -26,6 +26,9 @@ class FilterActionSetStatusTest : public QObject
 public:
     explicit FilterActionSetStatusTest(QObject *parent = 0);
     ~FilterActionSetStatusTest();
+private Q_SLOTS:
+    void shouldHaveDefaultValue();
+    void shouldHaveSieveRequires();
 };
 
 #endif // FILTERACTIONSETSTATUSTEST_H
diff --git a/mailcommon/filter/filteractions/filteractionwithstringlist.cpp \
b/mailcommon/filter/filteractions/filteractionwithstringlist.cpp index \
                817c49a..4720196 100644
--- a/mailcommon/filter/filteractions/filteractionwithstringlist.cpp
+++ b/mailcommon/filter/filteractions/filteractionwithstringlist.cpp
@@ -31,6 +31,7 @@ FilterActionWithStringList::FilterActionWithStringList( const \
QString &name, con  QWidget* FilterActionWithStringList::createParamWidget( QWidget \
*parent ) const  {
     PimCommon::MinimumComboBox *comboBox = new PimCommon::MinimumComboBox( parent );
+    comboBox->setObjectName(QLatin1String("combobox"));
     comboBox->setEditable( false );
     comboBox->addItems( mParameterList );
     setParamWidgetValue( comboBox );


[prev in list] [next in list] [prev in thread] [next in thread]