[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [muon/Plasma/5.2] libmuon/resources: Don't delete backends while processing signals
From:       Aleix Pol <aleixpol () kde ! org>
Date:       2015-03-23 2:10:17
Message-ID: E1YZron-0007vl-Qh () scm ! kde ! org
[Download RAW message or body]

Git commit 1836e1ba98edad4f1c695a618bda50090f819bf2 by Aleix Pol.
Committed on 23/03/2015 at 02:09.
Pushed by apol into branch 'Plasma/5.2'.

Don't delete backends while processing signals

Things go wrong

M  +2    -2    libmuon/resources/ResourcesModel.cpp

http://commits.kde.org/muon/1836e1ba98edad4f1c695a618bda50090f819bf2

diff --git a/libmuon/resources/ResourcesModel.cpp b/libmuon/resources/Resou=
rcesModel.cpp
index df4b791..9d87b34 100644
--- a/libmuon/resources/ResourcesModel.cpp
+++ b/libmuon/resources/ResourcesModel.cpp
@@ -112,7 +112,7 @@ void ResourcesModel::addResourcesBackend(AbstractResour=
cesBackend* backend)
     if(!backend->isValid()) {
         qWarning() << "Discarding invalid backend" << backend->name();
         CategoryModel::blacklistPlugin(backend->name());
-        delete backend;
+        backend->deleteLater();
         return;
     }
 =

@@ -267,7 +267,7 @@ void ResourcesModel::callerFetchingChanged()
         m_backends.removeAt(idx);
         m_resources.removeAt(idx);
         CategoryModel::blacklistPlugin(backend->name());
-        delete backend;
+        backend->deleteLater();
         return;
     }
 =


[prev in list] [next in list] [prev in thread] [next in thread]