[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [krecipes] src/tests/database: Rename test to show what encoding is used
From:       Adriaan de Groot <groot () kde ! org>
Date:       2015-02-25 11:09:24
Message-ID: E1YQZqG-0003xw-PC () scm ! kde ! org
[Download RAW message or body]

Git commit 1a84f1accb15f3cc518443a14dddfdaa248dadca by Adriaan de Groot.
Committed on 25/02/2015 at 10:25.
Pushed by adridg into branch 'master'.

Rename test to show what encoding is used

M  +3    -3    src/tests/database/encoding.cpp
M  +2    -2    src/tests/database/encoding.h

http://commits.kde.org/krecipes/1a84f1accb15f3cc518443a14dddfdaa248dadca

diff --git a/src/tests/database/encoding.cpp b/src/tests/database/encoding.cpp
index b5e3224..e81165c 100644
--- a/src/tests/database/encoding.cpp
+++ b/src/tests/database/encoding.cpp
@@ -48,12 +48,12 @@ void TestDatabaseEncoding::testSourceEncoding()
 	QCOMPARE( moose0.length(), 5 );
 	QCOMPARE( moose0.at(0), QChar(0xb5) );  // "micro" symbol
 	QCOMPARE( moose0, moose1 );
-	QCOMPARE( moose0, moose2 );
+	QCOMPARE( moose0, moose2 );  // This is the important bit: the string is representable in latin1
 	
 	qDebug() << "ORG" << moose0;
 }
 
-void TestDatabaseEncoding::testInsertProperty()
+void TestDatabaseEncoding::testInsertPropertyLatin1()
 {
 	QString moose1 = QString::fromUtf8(" µÃ¸Ã¸se");
 	QVERIFY( m_sqliteDatabase->ok() );
@@ -66,7 +66,7 @@ void TestDatabaseEncoding::testInsertProperty()
 	}
 }
 
-void TestDatabaseEncoding::testRetrieveProperty()
+void TestDatabaseEncoding::testRetrievePropertyLatin1()
 {
 	QString moose1 = QString::fromUtf8(" µÃ¸Ã¸se");
 	QVERIFY( m_sqliteDatabase->ok() );
diff --git a/src/tests/database/encoding.h b/src/tests/database/encoding.h
index abb05ae..7f7f042 100644
--- a/src/tests/database/encoding.h
+++ b/src/tests/database/encoding.h
@@ -23,8 +23,8 @@ private slots:
 	void initTestCase();
 	void cleanupTestCase();
 	void testSourceEncoding();
-	void testInsertProperty();
-	void testRetrieveProperty();
+	void testInsertPropertyLatin1();
+	void testRetrievePropertyLatin1();
 private:
 	RecipeDB * createDatabase( const QString & configFilename );
 	RecipeDB * m_sqliteDatabase;

[prev in list] [next in list] [prev in thread] [next in thread]