[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [calligra/calligra/2.9] plugins/vectorshape: BUG:340249 Load artistic text shape
From:       Inge Wallin <inge () lysator ! liu ! se>
Date:       2015-02-07 11:59:51
Message-ID: 1656060.bhiMcbovx9 () linux-iixz ! site
[Download RAW message or body]

On Saturday, February 07, 2015 05:05:52 Thorsten Zachmann wrote:
> Hello
> 
> On Friday, February 06, 2015 12:23:28 PM Inge Wallin wrote:
> > On Friday, February 06, 2015 08:57:00 Boudewijn Rempt wrote:
> > > Git commit 457eb87abcc4e2c45196940205d79f01c35fa5b7 by Boudewijn Rempt.
> > > Committed on 06/02/2015 at 08:55.
> > > Pushed by rempt into branch 'calligra/2.9'.
> > > 
> > > BUG:340249 Load artistic text shape
> > > 
> > > The artistic text shape was crowded out by the vector shape's support
> > > for loading svg. Embedded vector shapes are saved in a different way
> > > anyway, though it'd be good to figure out a different way to signal we
> > > want to load embedded svg than by having a shape refusing to loading it.
> > 
> > I suppose this means that the vector shape no longer loads any SVG at all,
> > right?  This means that the bug that we had a couple of weeks ago, namely
> > that SVG images are shown wrongly, is now reactivated.
> > 
> > The reason for that bug is that all SVG images got translated into path
> > shapes - badly - and were never saved back as SVG. Instead they were saved
> > as ODF path shapes and lots of information was lost.
> > 
> > We need to find a middle ground where artistic text is saved and loaded
> > correctly *and* actual included SVG images are not destroyed.
> > 
> > >                  // next three for backward compatibility with Calligra
> > >                  mimetype == QLatin1String("application/x-svm") ||
> > >                  mimetype == QLatin1String("application/x-emf") ||
> 
> How about making the loading priority of the atistic text shape higher so it
> is tried first? Then the vector shape can still load the svg and the
> artistic text shape should load its save data?

This could work.  I'm going to investigate this issue a bit deeper this 
weekend.  Your patch below might be what the doctor ordered but in that case I 
want to add some documentation about the priority. There is too much code with 
implicit assumptions already.


> What about the following patch?
> 
> diff --git a/plugins/artistictextshape/ArtisticTextShapeFactory.cpp
> b/plugins/artistictextshape/ArtisticTextShapeFactory.cpp
> index eb87699..239e26a 100644
> --- a/plugins/artistictextshape/ArtisticTextShapeFactory.cpp
> +++ b/plugins/artistictextshape/ArtisticTextShapeFactory.cpp
> @@ -31,7 +31,7 @@ ArtisticTextShapeFactory::ArtisticTextShapeFactory()
>  {
>      setToolTip(i18n("A shape which shows a single text line"));
>      setIconName(koIconNameCStrNeeded("currently falls back to x-shape-
> text","x-shape-text-artistic"));
> -    setLoadingPriority( 5 );
> +    setLoadingPriority( 10 );
>      setXmlElementNames(KoXmlNS::svg, QStringList("text"));
>  }
> 
> Thorsten
[prev in list] [next in list] [prev in thread] [next in thread]