[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kdepim/KDE/4.14] libkdepim/addressline: Improve unittest
From:       Montel Laurent <montel () kde ! org>
Date:       2015-02-04 8:34:31
Message-ID: E1YIvPr-0003Z3-R7 () scm ! kde ! org
[Download RAW message or body]

Git commit febc65766941c17fc82b56b83bf4e8d3396ba354 by Montel Laurent.
Committed on 04/02/2015 at 08:18.
Pushed by mlaurent into branch 'KDE/4.14'.

Improve unittest

M  +21   -0    libkdepim/addressline/autotests/baloocompletionemailtest.cpp
M  +1    -0    libkdepim/addressline/autotests/baloocompletionemailtest.h
M  +0    -1    libkdepim/addressline/baloocompletionemail.cpp

http://commits.kde.org/kdepim/febc65766941c17fc82b56b83bf4e8d3396ba354

diff --git a/libkdepim/addressline/autotests/baloocompletionemailtest.cpp b=
/libkdepim/addressline/autotests/baloocompletionemailtest.cpp
index b1fed0e..95c00e3 100644
--- a/libkdepim/addressline/autotests/baloocompletionemailtest.cpp
+++ b/libkdepim/addressline/autotests/baloocompletionemailtest.cpp
@@ -21,6 +21,7 @@
 #include "baloocompletionemailtest.h"
 #include "../baloocompletionemail.h"
 #include <qtest_kde.h>
+#include <QDebug>
 =

 BalooCompletionEmailTest::BalooCompletionEmailTest(QObject *parent)
     : QObject(parent)
@@ -142,4 +143,24 @@ void BalooCompletionEmailTest::shouldReturnEmailListWh=
enDomainListIsNotNull()
     QCOMPARE(completion.cleanupEmailList(), emailList);
 }
 =

+void BalooCompletionEmailTest::shouldDontDuplicateEmailWhenUseCase()
+{
+    KPIM::BalooCompletionEmail completion;
+    QStringList emailList;
+    emailList << QLatin1String("foo");
+    emailList << QLatin1String("foo2");
+    emailList << QLatin1String("foo3");
+    emailList << QLatin1String("foo4");
+    emailList << QLatin1String("foo5");
+    emailList << QLatin1String("foo6");
+
+    QStringList caseEmailList;
+    caseEmailList << QLatin1String("Foo");
+    caseEmailList << QLatin1String("fOo2");
+    caseEmailList << QLatin1String("FOo3");
+    completion.setEmailList((QStringList() << emailList<<caseEmailList));
+    QCOMPARE(completion.cleanupEmailList(), emailList);
+
+}
+
 QTEST_KDEMAIN(BalooCompletionEmailTest, NoGUI)
diff --git a/libkdepim/addressline/autotests/baloocompletionemailtest.h b/l=
ibkdepim/addressline/autotests/baloocompletionemailtest.h
index 47cb248..f49fd25 100644
--- a/libkdepim/addressline/autotests/baloocompletionemailtest.h
+++ b/libkdepim/addressline/autotests/baloocompletionemailtest.h
@@ -38,6 +38,7 @@ private Q_SLOTS:
     void shouldReturnEmptyListWhenAllBlackListed();
     void shouldExcludeDomain();
     void shouldReturnEmailListWhenDomainListIsNotNull();
+    void shouldDontDuplicateEmailWhenUseCase();
 };
 =

 #endif // BALOOCOMPLETIONEMAILTEST_H
diff --git a/libkdepim/addressline/baloocompletionemail.cpp b/libkdepim/add=
ressline/baloocompletionemail.cpp
index d352448..e922863 100644
--- a/libkdepim/addressline/baloocompletionemail.cpp
+++ b/libkdepim/addressline/baloocompletionemail.cpp
@@ -66,4 +66,3 @@ QStringList BalooCompletionEmail::cleanupEmailList() const
     }
     return hashEmail.values();
 }
-

[prev in list] [next in list] [prev in thread] [next in thread]