[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [calligra/calligra/2.9] krita/ui: Remove check for broken Intel video drivers
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2014-12-22 11:40:25
Message-ID: alpine.LNX.2.00.1412221240150.25970 () calcifer ! valdyas ! org
[Download RAW message or body]


Ah, that would be cool :-)

On Mon, 22 Dec 2014, Dmitry Kazakov wrote:

> Most probably, the fix is caused my MVC merge, because it also works here now, \
> although I didn't update my drivers :) 
> On Mon, Dec 22, 2014 at 3:30 PM, Boudewijn Rempt <boud@valdyas.org> wrote:
> Git commit dab7d86c077e8be7d1374ba84076d9c9f186ba41 by Boudewijn Rempt.
> Committed on 22/12/2014 at 10:31.
> Pushed by rempt into branch 'calligra/2.9'.
> 
> Remove check for broken Intel video drivers
> 
> Apparently, Intel fixed their OpenGL drivers. I tested on my bevy of intel
> development devices, and the issue is no longer reproducible.
> 
> M  +0    -38   krita/ui/KisViewManager.cpp
> 
> http://commits.kde.org/calligra/dab7d86c077e8be7d1374ba84076d9c9f186ba41
> 
> diff --git a/krita/ui/KisViewManager.cpp b/krita/ui/KisViewManager.cpp
> index 0ed87d1..bdb37b6 100644
> --- a/krita/ui/KisViewManager.cpp
> +++ b/krita/ui/KisViewManager.cpp
> @@ -1124,44 +1124,6 @@ void KisViewManager::showStatusBar(bool toggled)
> void KisViewManager::showJustTheCanvas(bool toggled)
> {
> KisConfig cfg;
> -
> -    /**
> - * Workaround for a broken Intel video driver on Windows :(
> - * See bug 330040
> - */
> -#if defined HAVE_OPENGL && defined Q_OS_WIN32
> -
> -    if (toggled && cfg.useOpenGL()) {
> -        QString renderer((const char*)glGetString(GL_RENDERER));
> -        bool failingDriver = renderer.startsWith("Intel(R) HD Graphics");
> -
> -        if (failingDriver &&
> -                cfg.hideStatusbarFullscreen() &&
> -                cfg.hideDockersFullscreen() &&
> -                cfg.hideTitlebarFullscreen() &&
> -                cfg.hideMenuFullscreen() &&
> -                cfg.hideToolbarFullscreen() &&
> -                cfg.hideScrollbarsFullscreen()) {
> -
> -            int result =
> -                    QMessageBox::warning(0,
> -                                         i18nc("@title:window", "Failing video \
>                 adapter"),
> -                                         i18n("Intel(R) HD Graphics video adapters \
>                 "
> -                                              "are known to have problems with \
>                 running "
> -                                              "Krita in pure canvas only mode. At \
>                 least "
> -                                              "one UI control must be shown to "
> -                                              "workaround it.\n\nShow the scroll \
>                 bars?"),
> -                                         QMessageBox::Yes | QMessageBox::No,
> -                                         QMessageBox::No);
> -
> -            if (result == QMessageBox::Yes) {
> -                cfg.setHideScrollbarsFullscreen(false);
> -            }
> -        }
> -    }
> -
> -#endif /* defined HAVE_OPENGL && defined Q_OS_WIN32 */
> -
> KisMainWindow* main = mainWindow();
> 
> if(!main) {
> 
> 
> 
> 
> --
> Dmitry Kazakov
> 
> 



[prev in list] [next in list] [prev in thread] [next in thread]