[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kdepim] /: Remove virtual when not necessary
From:       laurent Montel <montel () kde ! org>
Date:       2014-12-02 15:43:28
Message-ID: 2469998.Aizf2f6K6n () linux-19td
[Download RAW message or body]

Le Tuesday 02 December 2014 15:39:31 David Jarvie a écrit :
> > http://commits.kde.org/kdepim/838102fb1d01f80f21b46d1f3413c02716ff2200
> 
> Is there a particular reason to remove 'virtual' when it is not necessary?
> I prefer to keep it for documentation purposes.

Q_DECL_OVERRIDE is enough for it.
If it's not virtual Q_DECL_OVERRIDE will fail at the compile
=> so we know that it's real virtual and derive from a parent.


Regards


-- 
Laurent Montel | laurent.montel@kdab.com | KDE/Qt Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company
Tel. France +33 (0)4 90 84 08 53,  http://www.kdab.fr


[prev in list] [next in list] [prev in thread] [next in thread]