From kde-commits Tue Dec 02 15:39:31 2014 From: "David Jarvie" Date: Tue, 02 Dec 2014 15:39:31 +0000 To: kde-commits Subject: Re: [kdepim] /: Remove virtual when not necessary Message-Id: X-MARC-Message: https://marc.info/?l=kde-commits&m=141753478718007 On Tue, December 2, 2014 7:15 am, Montel Laurent wrote: > Git commit 838102fb1d01f80f21b46d1f3413c02716ff2200 by Montel Laurent. > Committed on 02/12/2014 at 07:15. > Pushed by mlaurent into branch 'master'. > > Remove virtual when not necessary > > M +3 -3 akonadiconsole/jobtrackermodel.h > M +1 -1 akregator/src/articleviewer.h > M +3 -3 calendarsupport/kcalmodel.h > M +1 -1 calendarviews/agenda/timelabels.h > M +3 -3 calendarviews/month/monthview.h > M +3 -3 incidenceeditor-ng/freebusyitemmodel.h > M +3 -3 incidenceeditor-ng/freeperiodmodel.h > M +3 -3 kaddressbook/xxport/csv/qcsvmodel.h > M +5 -5 kalarm/emailidcombo.h > M +5 -5 kalarm/lib/checkbox.h > M +5 -5 kalarm/lib/colourbutton.h > M +5 -5 kalarm/lib/combobox.h > M +5 -5 kalarm/lib/groupbox.h > M +3 -3 kalarm/lib/lineedit.h > M +6 -6 kalarm/lib/pushbutton.h > M +5 -5 kalarm/lib/radiobutton.h > M +5 -5 kalarm/lib/slider.h > M +9 -9 kalarm/lib/spinbox.h > M +9 -9 knotes/notes/knote.h > M +4 -4 kontact/src/iconsidepane.h > M +2 -2 libkdepim/addressline/addresseelineedit.h > M +1 -1 libkdepim/multiplyingline/multiplyingline.h > M +3 -3 libkdepim/widgets/customlogwidget.h > M +1 -1 mailcommon/folder/foldertreeview.h > M +1 -1 mailcommon/folder/foldertreewidget.h > M +1 -1 mailcommon/folder/foldertreewidgetproxymodel.h > M +7 -7 messagecomposer/attachment/attachmentmodel.h > M +2 -2 messagecomposer/composer/composerlineedit.h > M +1 -1 messagecomposer/composer/kmeditor.h > M +1 -1 messagecomposer/job/aliasesexpandjob.h > M +1 -1 messagecomposer/job/attachmentfrompublickeyjob.h > M +5 -5 messagelist/core/model.h > M +8 -8 messagelist/core/view.h > M +4 -4 messagelist/storagemodel.h > M +6 -6 messagelist/utils/themeeditor.h > M +5 -5 mobile/contacts/imagewidget.h > M +1 -1 mobile/lib/breadcrumbnavigation.h > M +1 -1 mobile/lib/kdeclarativemainview.h > M +2 -2 mobile/notes/notelistproxy.h > M +3 -3 mobile/tasks/tasklistproxy.h > > http://commits.kde.org/kdepim/838102fb1d01f80f21b46d1f3413c02716ff2200 Is there a particular reason to remove 'virtual' when it is not necessary? I prefer to keep it for documentation purposes. -- David Jarvie. KDE developer. KAlarm author - http://www.astrojar.org.uk/kalarm