[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [umbrello] umbrello: Coverity check on master@bd16929, CID 71422: Unchecked dynamic_cast (FORWARD_NU
From:       Ralf Habacker <ralf.habacker () freenet ! de>
Date:       2014-12-01 4:44:30
Message-ID: E1XvIqc-0005MJ-P5 () scm ! kde ! org
[Download RAW message or body]

Git commit 55872c008f8dc0653edd7154f97a15c6efc4c7ab by Ralf Habacker.
Committed on 28/11/2014 at 22:26.
Pushed by habacker into branch 'master'.

Coverity check on master@bd16929, CID 71422: Unchecked dynamic_cast (FORWARD_NULL).

CCBUG:340646

M  +4    -0    umbrello/classifiercodedocument.cpp

http://commits.kde.org/umbrello/55872c008f8dc0653edd7154f97a15c6efc4c7ab

diff --git a/umbrello/classifiercodedocument.cpp b/umbrello/classifiercodedocument.cpp
index 6c49b33..a2e05e1 100644
--- a/umbrello/classifiercodedocument.cpp
+++ b/umbrello/classifiercodedocument.cpp
@@ -130,6 +130,10 @@ bool ClassifierCodeDocument::hasObjectVectorClassFields()
         if((*it)->getClassFieldType() != CodeClassField::Attribute)
         {
             UMLRole * role = dynamic_cast<UMLRole*>((*it)->getParentObject());
+            if (!role) {
+                uError() << "invalid parent object type";
+                return false;
+            }
             QString multi = role->multiplicity();
             if (
                 multi.contains(QRegExp(QLatin1String("[23456789\\*]"))) ||

[prev in list] [next in list] [prev in thread] [next in thread]