[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [umbrello] unittests: Coverity check on master@375ea16 CIDs 83526, 83527, 83528, 83529, 83530 :
From:       Oliver Kellogg <okellogg () users ! sourceforge ! net>
Date:       2014-11-30 19:07:13
Message-ID: E1Xv9px-0004oC-0s () scm ! kde ! org
[Download RAW message or body]

Git commit 9324cf30e4017d0f37a95d47da96882a8d713199 by Oliver Kellogg.
Committed on 30/11/2014 at 19:06.
Pushed by okellogg into branch 'master'.

Coverity check on master@375ea16 CIDs 83526, 83527, 83528, 83529, 83530 :
Logically dead code in file unittests/TEST_basictypes.cpp

- CID 83526: At function test_Corner_toString_fromString() for-loop,
  - use "<=" as comparison operator for staying in loop;
  - replace ++i by i *= 2 on iteration action. Reason: The values of
    the Corner enum are represented as 0x1, 0x2, 0x4, 0x8.

- CID 83527: At function test_RoleType_toString_fromString() for-loop,
  use "<=" as comparison operator for staying in loop.

- CID 83528: At function test_RoleType_toString_fromString() for-loop,
  use "<=" as comparison operator for staying in loop.

- CID 83529: At function test_Region_toString_fromString() for-loop,
  use "<=" as comparison operator for staying in loop.

- CID 83530: At function test_ProgrammingLanguage_toString_fromString()
  for-loop, use "<=" as comparison operator for staying in loop.

CCBUG:340646

M  +5    -5    unittests/TEST_basictypes.cpp

http://commits.kde.org/umbrello/9324cf30e4017d0f37a95d47da96882a8d713199

diff --git a/unittests/TEST_basictypes.cpp b/unittests/TEST_basictypes.cpp
index 21a74d4..3b4b70d 100644
--- a/unittests/TEST_basictypes.cpp
+++ b/unittests/TEST_basictypes.cpp
@@ -279,7 +279,7 @@ void TEST_basictypes::test_SequenceMessage_toString_fromString()
 
 void TEST_basictypes::test_RoleType_toString_fromString()
 {
-    for (int i = Uml::RoleType::A; i == Uml::RoleType::B; ++i) {
+    for (int i = Uml::RoleType::A; i <= Uml::RoleType::B; ++i) {
         Uml::RoleType::Enum at = Uml::RoleType::fromString(
                                       Uml::RoleType::toString(
                                           Uml::RoleType::fromInt(i)));
@@ -291,7 +291,7 @@ void TEST_basictypes::test_RoleType_toString_fromString()
 
 void TEST_basictypes::test_ParameterDirection_toString_fromString()
 {
-    for (int i = Uml::ParameterDirection::In; i == Uml::ParameterDirection::Out; ++i) {
+    for (int i = Uml::ParameterDirection::In; i <= Uml::ParameterDirection::Out; ++i) {
         Uml::ParameterDirection::Enum at = Uml::ParameterDirection::fromString(
                                       Uml::ParameterDirection::toString(
                                           Uml::ParameterDirection::fromInt(i)));
@@ -303,7 +303,7 @@ void TEST_basictypes::test_ParameterDirection_toString_fromString()
 
 void TEST_basictypes::test_ProgrammingLanguage_toString_fromString()
 {
-    for (int i = Uml::ProgrammingLanguage::ActionScript; i == Uml::ProgrammingLanguage::Reserved; ++i) {
+    for (int i = Uml::ProgrammingLanguage::ActionScript; i < Uml::ProgrammingLanguage::Reserved; ++i) {
         Uml::ProgrammingLanguage::Enum at = Uml::ProgrammingLanguage::fromString(
                                       Uml::ProgrammingLanguage::toString(
                                           Uml::ProgrammingLanguage::fromInt(i)));
@@ -315,7 +315,7 @@ void TEST_basictypes::test_ProgrammingLanguage_toString_fromString()
 
 void TEST_basictypes::test_Region_toString_fromString()
 {
-    for (int i = Uml::Region::Error; i == Uml::Region::SouthWest; ++i) {
+    for (int i = Uml::Region::Error; i <= Uml::Region::SouthWest; ++i) {
         Uml::Region::Enum at = Uml::Region::fromString(
                                       Uml::Region::toString(
                                           Uml::Region::fromInt(i)));
@@ -327,7 +327,7 @@ void TEST_basictypes::test_Region_toString_fromString()
 
 void TEST_basictypes::test_Corner_toString_fromString()
 {
-    for (int i = Uml::Corner::TopLeft; i == Uml::Corner::BottomLeft; ++i) {
+    for (int i = Uml::Corner::TopLeft; i <= Uml::Corner::BottomLeft; i *= 2) {
         Uml::Corner::Enum at = Uml::Corner::fromString(
                                       Uml::Corner::toString(
                                           Uml::Corner::fromInt(i)));
[prev in list] [next in list] [prev in thread] [next in thread]