[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [muon/frameworks] libmuon/backends/PackageKitBackend: Properly notify that some resource information
From:       Aleix Pol <aleixpol () kde ! org>
Date:       2014-10-01 0:44:30
Message-ID: E1XZ81u-0005Eh-W7 () scm ! kde ! org
[Download RAW message or body]

Git commit 97e3b4ecb923f91a87da7bc3fee9ddc4b676a455 by Aleix Pol.
Committed on 01/10/2014 at 00:39.
Pushed by apol into branch 'frameworks'.

Properly notify that some resource information changed

We are using stateChanged for that for the moment, so just do it when
the details arrive.
Also remove the licenseChanged property+signal. It was unused

M  +3    -4    libmuon/backends/PackageKitBackend/PackageKitResource.cpp
M  +0    -4    libmuon/backends/PackageKitBackend/PackageKitResource.h

http://commits.kde.org/muon/97e3b4ecb923f91a87da7bc3fee9ddc4b676a455

diff --git a/libmuon/backends/PackageKitBackend/PackageKitResource.cpp \
b/libmuon/backends/PackageKitBackend/PackageKitResource.cpp index f2a4bca..44ff850 \
                100644
--- a/libmuon/backends/PackageKitBackend/PackageKitResource.cpp
+++ b/libmuon/backends/PackageKitBackend/PackageKitResource.cpp
@@ -322,15 +322,14 @@ void PackageKitResource::setDetails(const PackageKit::Details & \
details)  {
     if (details.packageId() != m_availablePackageId)
         return;
-    qDebug() << "Got details for" << m_availablePackageId;
-    bool newLicense = (details.license() != m_license);
+
     m_license = details.license();
     m_group = details.group();
     m_detail = details.description();
     m_url = details.url();
     m_size = details.size();
-    if (newLicense)
-        emit licenseChanged();
+
+    emit stateChanged();
 }
 
 void PackageKitResource::fetchChangelog()
diff --git a/libmuon/backends/PackageKitBackend/PackageKitResource.h \
b/libmuon/backends/PackageKitBackend/PackageKitResource.h index 95ec875..ee9306f \
                100644
--- a/libmuon/backends/PackageKitBackend/PackageKitResource.h
+++ b/libmuon/backends/PackageKitBackend/PackageKitResource.h
@@ -29,7 +29,6 @@ class PackageKitBackend;
 class PackageKitResource : public AbstractResource
 {
     Q_OBJECT
-    Q_PROPERTY(QString license READ license NOTIFY licenseChanged)
     public:
         explicit PackageKitResource(const QString &packageId, \
PackageKit::Transaction::Info info, const QString &summary, PackageKitBackend* \
parent);  virtual QString packageName() const;
@@ -62,9 +61,6 @@ class PackageKitResource : public AbstractResource
         void setDetails(const PackageKit::Details& details);
         void resetPackageIds();
 
-    signals:
-        void licenseChanged();
-
     private:
         PackageKitBackend * m_backend;
         QString m_installedPackageId;


[prev in list] [next in list] [prev in thread] [next in thread]