[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [plasma-desktop/Plasma/5.1] applets/taskmanager/package/contents/ui: Delay handing the model to the
From:       Eike Hein <hein () kde ! org>
Date:       2014-09-30 20:08:28
Message-ID: E1XZ3im-0007lj-CJ () scm ! kde ! org
[Download RAW message or body]

Git commit 7c8c8d2e96b0a6c93a9582e909a210a70797ed15 by Eike Hein.
Committed on 30/09/2014 at 20:00.
Pushed by hein into branch 'Plasma/5.1'.

Delay handing the model to the repeater until QML is done initializing the Backend.

Qt Quick gets done constructing the repeater before all the props on the
backend are initialized from config, potentially causing unnecessary work
there (specifically row moves).

Also avoids a gnarly mystery crash in QQuickRepeater that I still can't
quite figure out how to write a testcase for ...
BUG:334771

M  +1    -1    applets/taskmanager/package/contents/ui/main.qml

http://commits.kde.org/plasma-desktop/7c8c8d2e96b0a6c93a9582e909a210a70797ed15

diff --git a/applets/taskmanager/package/contents/ui/main.qml \
b/applets/taskmanager/package/contents/ui/main.qml index 9be7ca5..a08cf55 100644
--- a/applets/taskmanager/package/contents/ui/main.qml
+++ b/applets/taskmanager/package/contents/ui/main.qml
@@ -89,6 +89,7 @@ Item {
 
         Component.onCompleted: {
             launchers = plasmoid.configuration.launchers;
+            visualModel.model = backend.tasksModel;
         }
     }
 
@@ -195,7 +196,6 @@ Item {
     VisualDataModel {
         id: visualModel
 
-        model: backend.tasksModel
         delegate: Task {}
     }
 


[prev in list] [next in list] [prev in thread] [next in thread]