[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [libechonest] src: in parseDynamicLookahead only add a song if it has any value set (fixes test Play
From:       Leo Franchi <lfranchi () kde ! org>
Date:       2014-09-13 2:21:16
Message-ID: E1XScxg-00062T-OA () scm ! kde ! org
[Download RAW message or body]

Git commit 04d3efd0a5c6611a7d2c72e03643120a891bfdb3 by Leo Franchi, on beha=
lf of Stefan Derkits.
Committed on 29/05/2014 at 20:41.
Pushed by lfranchi into branch 'master'.

in parseDynamicLookahead only add a song if it has any value set (fixes tes=
t PlaylistTest::testNewDynamicAPI()

M  +2    -1    src/Parsing.cpp

http://commits.kde.org/libechonest/04d3efd0a5c6611a7d2c72e03643120a891bfdb3

diff --git a/src/Parsing.cpp b/src/Parsing.cpp
index bd1b337..acf6457 100644
--- a/src/Parsing.cpp
+++ b/src/Parsing.cpp
@@ -945,7 +945,8 @@ Echonest::SongList Echonest::Parser::parseDynamicLookah=
ead( QXmlStreamReader& xm
 =

             xml.readNext();
         }
-        lookahead.append(song);
+        if ( !( song.id().isEmpty() && song.title().isEmpty() && song.arti=
stId().isEmpty() && song.artistName().isEmpty() ) )
+            lookahead.append(song);
 =

         xml.readNext();
     }

[prev in list] [next in list] [prev in thread] [next in thread]