[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kdepim/KDE/4.14] libkdepim/addressline: Adapt patch from Till Adam to avoid to search in baloo 
From:       Till Adam <adam () kde ! org>
Date:       2014-09-02 11:47:29
Message-ID: 3009329.W8qeuOd7Uy () till ! kdab ! com
[Download RAW message or body]

On Tuesday, September 02, 2014 12:17:41 PM Vishesh Handa wrote:
> On Tue, Sep 2, 2014 at 7:39 AM, Montel Laurent <montel@kde.org> wrote:
> > Git commit d6806c4d56e4b1f8ef76a1d080cb664c55a3794a by Montel Laurent.
> > Committed on 02/09/2014 at 05:36.
> > Pushed by mlaurent into branch 'KDE/4.14'.
> > 
> > Adapt patch from Till Adam to avoid to search in baloo when string size
> > <3, and without Delay
> 
> Why? Is it too slow or something?

Triggering a search right away and without lower size limit means that 
immediately after the first key press a search for a single letter match is 
triggered, immediately followed by one for two letters. Both have lots and 
lots of hit, obviously, at least on my large database and the search blocks 
(at least on Windows) for several seconds each time. That means that by the 
time those two return and the third search is fired off (which is fast and 
returns much fewer hits) I have been sitting waiting for a blocked composer 
for 5 or more seconds. The search results of the first and second search are 
not meaningful anyway, so it's better to compress the first few keystrokes and, 
for extremely slow typers, also make sure we avoid searching for super short 
strings.
[prev in list] [next in list] [prev in thread] [next in thread]