[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kdepim-runtime/frameworks] /: kdebug--
From:       "David Jarvie" <djarvie () kde ! org>
Date:       2014-08-04 16:44:28
Message-ID: f5523198465dc89039960f7ff35b4a87.squirrel () www6 ! sensical ! net
[Download RAW message or body]

On Mon, August 4, 2014 6:20 am, Montel Laurent wrote:
> Git commit 312b3e276ba6dee92a671f0eccf9d4f81ab03f40 by Montel Laurent.
> Committed on 04/08/2014 at 05:20.
> Pushed by mlaurent into branch 'frameworks'.
>
> kdebug--
>
> M  +1    -1    kioslave/akonadislave.cpp
> M  +2    -2    plugins/CMakeLists.txt
> M  +8    -7    plugins/akonadi_serializer_kalarm.cpp
> A  +23   -0    plugins/akonadi_serializer_kalarm_debug.cpp     [License:
> LGPL (v2+)]
> A  +27   -0    plugins/akonadi_serializer_kalarm_debug.h     [License:
> LGPL (v2+)]
> M  +4    -3    plugins/akonadi_serializer_mail.cpp
> A  +23   -0    plugins/akonadi_serializer_mail_debug.cpp     [License:
> LGPL (v2+)]
> A  +27   -0    plugins/akonadi_serializer_mail_debug.h     [License: LGPL
> (v2+)]
> M  +1    -1    plugins/autotests/CMakeLists.txt
> M  +2    -2    resources/maildir/autotests/synctest.cpp
> M  +5    -5    resources/maildir/libmaildir/keycache.cpp
> M  +21   -20   resources/maildir/maildirresource.cpp
>
> http://commits.kde.org/kdepim-runtime/312b3e276ba6dee92a671f0eccf9d4f81ab03f40
>
...
> diff --git a/plugins/akonadi_serializer_kalarm.cpp
> b/plugins/akonadi_serializer_kalarm.cpp
> index b87a67c..a0c144c 100644
> --- a/plugins/akonadi_serializer_kalarm.cpp
> +++ b/plugins/akonadi_serializer_kalarm.cpp
...
> @@ -81,7 +82,7 @@ bool SerializerPluginKAlarm::deserialize(Item& item,
> const QByteArray& label, QI
>      {
>          Attribute* a = item.attribute(dummy.type());
>          if (!a)
> -            kError(5954) << "deserialize(): Event with uid" << event.id()
> << "contains null attribute";
> +            qCCritical(AKONADI_SERIALIZER_KALARM_LOG) << "deserialize():
> Event with uid" << event.id() << "contains null attribute";
>          else
>          {
>              EventAttribute* evAttr = dynamic_cast<EventAttribute*>(a);

Is it correct to replace kError() with qCCritical()? kError() isn't fatal,
but my reading of the Qt documentation is that qCCritical() *is* fatal.
Because qCError() doesn't exist, shouldn't kError() be replaced by
qCWarning()?

-- 
David Jarvie.
KDE developer.
KAlarm author - http://www.astrojar.org.uk/kalarm

[prev in list] [next in list] [prev in thread] [next in thread]