[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [trojita] src: Simplify bytearray -> text conversion for body =?iso-8859-1?Q?parts?=
From:       Jan_Kundrát <jkt () flaska ! net>
Date:       2014-08-04 13:49:25
Message-ID: e795746b-2849-418e-b6a1-e59d38f8babc () flaska ! net
[Download RAW message or body]

On Monday, 4 August 2014 15:56:01 CEST, Vishesh Handa wrote:
>> +    case RolePartUnicodeText:
>> +        if (m_mimeType.startsWith("text/")) {
>
> Minor nitpick - QLatin1String would be better.

Hi Vishesh, m_mimeType is a QByteArray, so a QLatin1String cannot be used 
here. We're also already building with -DQT_NO_CAST_FROM_ACII (at least our 
own parts, not the code copied verbatim from other projects).

With kind regards,
Jan

-- 
Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/
[prev in list] [next in list] [prev in thread] [next in thread]