[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kdevplatform/1.7] plugins: The error is shown on the outputview, so mark it as such
From:       Aleix Pol <aleixpol () kde ! org>
Date:       2014-08-01 0:18:10
Message-ID: E1XD0Xy-00036L-AK () scm ! kde ! org
[Download RAW message or body]

Git commit 166e4ca40d9463d33f22dbcd014e515f191df45f by Aleix Pol.
Committed on 01/08/2014 at 00:17.
Pushed by apol into branch '1.7'.

The error is shown on the outputview, so mark it as such

This way we don't get an ugly messagebox, when it's in hte output view

M  +1    -1    plugins/execute/nativeappjob.cpp
M  +1    -1    plugins/executescript/scriptappjob.cpp

http://commits.kde.org/kdevplatform/166e4ca40d9463d33f22dbcd014e515f191df45f

diff --git a/plugins/execute/nativeappjob.cpp b/plugins/execute/nativeappjob.cpp
index 38167f5..bbb7b65 100644
--- a/plugins/execute/nativeappjob.cpp
+++ b/plugins/execute/nativeappjob.cpp
@@ -195,7 +195,7 @@ void NativeAppJob::processError( QProcess::ProcessError error )
 {
     if( error == QProcess::FailedToStart )
     {
-        setError( -1 );
+        setError( FailedShownError );
         QString errmsg =  i18n("*** Could not start program '%1'. Make sure that the "
                            "path is specified correctly ***", proc->program().join(" ") );
         appendLine( errmsg );
diff --git a/plugins/executescript/scriptappjob.cpp b/plugins/executescript/scriptappjob.cpp
index 05c9eeb..7f098ff 100644
--- a/plugins/executescript/scriptappjob.cpp
+++ b/plugins/executescript/scriptappjob.cpp
@@ -230,7 +230,7 @@ void ScriptAppJob::processError( QProcess::ProcessError error )
     kDebug() << proc->errorString();
     if( error == QProcess::FailedToStart )
     {
-        setError( -1 );
+        setError( FailedShownError );
         QString errmsg =  i18n("*** Could not start program '%1'. Make sure that the "
                            "path is specified correctly ***", proc->program().join(" ") );
         appendLine( errmsg );
[prev in list] [next in list] [prev in thread] [next in thread]