[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kbibtex] src: Replacing deleteLater() with normal delete
From:       Thomas Fischer <fischer () unix-ag ! uni-kl ! de>
Date:       2014-05-31 21:11:32
Message-ID: E1WqqYu-0007oo-UF () scm ! kde ! org
[Download RAW message or body]

Git commit f2d02f9d8b5d9e6d4ea799cf46c13594372d59b4 by Thomas Fischer.
Committed on 31/05/2014 at 21:10.
Pushed by thomasfischer into branch 'master'.

Replacing deleteLater() with normal delete

Replacing calls to an object's deleteLater() with plain delete object
calls. The usage of QPointer should have made using deleteLater no
longer necessary.

M  +3    -2    src/gui/element/associatedfilesui.cpp
M  +1    -1    src/gui/element/findpdfui.cpp
M  +2    -2    src/parts/part.cpp

http://commits.kde.org/kbibtex/f2d02f9d8b5d9e6d4ea799cf46c13594372d59b4

diff --git a/src/gui/element/associatedfilesui.cpp b/src/gui/element/associatedfilesui.cpp
index 48a68de..dc91fc2 100644
--- a/src/gui/element/associatedfilesui.cpp
+++ b/src/gui/element/associatedfilesui.cpp
@@ -157,7 +157,7 @@ bool AssociatedFilesUI::associateUrl(const QUrl &url, QSharedPointer<Entry> &ent
         }
     }
 
-    dlg->deleteLater();
+    delete dlg;
     return accepted && success;
 }
 
@@ -182,7 +182,8 @@ QString AssociatedFilesUI::associateUrl(const QUrl &url, const QString &entryId,
             success &= !referenceString.isEmpty();
         }
     }
-    dlg->deleteLater();
+
+    delete dlg;
     return accepted && success ? referenceString : QString();
 }
 
diff --git a/src/gui/element/findpdfui.cpp b/src/gui/element/findpdfui.cpp
index 647547b..1c06446 100644
--- a/src/gui/element/findpdfui.cpp
+++ b/src/gui/element/findpdfui.cpp
@@ -410,7 +410,7 @@ void FindPDFUI::interactiveFindPDF(Entry &entry, const File &bibtexFile, QWidget
     if (dlg->exec() == KDialog::Accepted) {
         widget->apply(entry, bibtexFile);
     }
-    dlg->deleteLater();
+    delete dlg;
 }
 
 void FindPDFUI::apply(Entry &entry, const File &bibtexFile)
diff --git a/src/parts/part.cpp b/src/parts/part.cpp
index d083457..a2d2017 100644
--- a/src/parts/part.cpp
+++ b/src/parts/part.cpp
@@ -344,7 +344,7 @@ public:
                 connect(dlg, SIGNAL(defaultClicked()), &settingsWidget, SLOT(resetToDefaults()));
                 dlg->exec();
                 settingsWidget.saveProperties(bibTeXFile);
-                dlg->deleteLater();
+                delete dlg;
             } else if ((fet = dynamic_cast<FileExporterToolchain *>(exporter)) != NULL) {
                 QPointer<KDialog> dlg = new KDialog(p->widget());
                 SettingsFileExporterPDFPSWidget settingsWidget(dlg);
@@ -358,7 +358,7 @@ public:
                 dlg->exec();
                 settingsWidget.saveState();
                 fet->reloadConfig();
-                dlg->deleteLater();
+                delete dlg;
             }
         }
 

[prev in list] [next in list] [prev in thread] [next in thread]