[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [plasma-mediacenter] libs/test: Test for ImageCache
From:       Shantanu Tushar <shantanu () kde ! org>
Date:       2014-05-03 7:12:58
Message-ID: E1WgU82-0001ot-Fy () scm ! kde ! org
[Download RAW message or body]

Git commit 27ed9c3deace36f20b4515be0da5c30026ee273a by Shantanu Tushar.
Committed on 03/05/2014 at 07:10.
Pushed by shantanu into branch 'master'.

Test for ImageCache

M  +1    -0    libs/test/CMakeLists.txt
M  +13   -1    libs/test/itemcachetest.cpp
M  +1    -0    libs/test/itemcachetest.h

http://commits.kde.org/plasma-mediacenter/27ed9c3deace36f20b4515be0da5c30026ee273a

diff --git a/libs/test/CMakeLists.txt b/libs/test/CMakeLists.txt
index ffaeb91..43708d6 100644
--- a/libs/test/CMakeLists.txt
+++ b/libs/test/CMakeLists.txt
@@ -20,3 +20,4 @@ pmc_test(lastfmimagefetchertest)
 pmc_test(pmcmediatest)
 pmc_test(mediatest)
 pmc_test(mediacentertest)
+pmc_test(itemcachetest)
diff --git a/libs/test/itemcachetest.cpp b/libs/test/itemcachetest.cpp
index 0dc4448..e6dee33 100644
--- a/libs/test/itemcachetest.cpp
+++ b/libs/test/itemcachetest.cpp
@@ -29,7 +29,19 @@ void ItemCacheTest::shouldInsertAndReturnTheSameObjectNextTime()
 {
     ItemCache<Artist> artists;
 
-    artists.getById("Shaan", true);
+    auto artist = artists.getById("Shaan", true);
+
+    QCOMPARE(artist, artists.getById("Shaan"));
+    QCOMPARE(artist, artists.getById("Shaan", true));
+}
+
+void ItemCacheTest::shouldNotInsertWhenNotAskedTo()
+{
+    ItemCache<Artist> artists;
+
+    auto artist = artists.getById("Shaan");
+
+    QVERIFY2(artist.isNull(), "Was expecting a null artist");
 }
 
 #include "itemcachetest.moc"
diff --git a/libs/test/itemcachetest.h b/libs/test/itemcachetest.h
index e5c8c45..4fc6807 100644
--- a/libs/test/itemcachetest.h
+++ b/libs/test/itemcachetest.h
@@ -26,6 +26,7 @@ class ItemCacheTest : public QObject
     Q_OBJECT
 private Q_SLOTS:
     void shouldInsertAndReturnTheSameObjectNextTime();
+    void shouldNotInsertWhenNotAskedTo();
 };
 
 #endif // ITEMCACHETEST_H
[prev in list] [next in list] [prev in thread] [next in thread]