[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kdeplasma-addons] applets/konsoleprofiles/package/contents/ui: Don't try to be clever with the high
From:       Eike Hein <hein () kde ! org>
Date:       2014-04-30 15:33:05
Message-ID: E1WfWVN-0000Ad-J8 () scm ! kde ! org
[Download RAW message or body]

Git commit 9b1f219f6ad05c2dbfcb8b6fb608e24aaf9cdbac by Eike Hein.
Committed on 30/04/2014 at 15:31.
Pushed by hein into branch 'master'.

Don't try to be clever with the highlight item opacity.

Turns out the original author's intent to tie the existence of the
highlight deco strictly to mouse contact is basically incompatible
with the desires of keyboard-only users, who need persistent and
immediate feedback on the view's current item.

BUG:313734

M  +0    -13   applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml

http://commits.kde.org/kdeplasma-addons/9b1f219f6ad05c2dbfcb8b6fb608e24aaf9cdbac

diff --git a/applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml \
b/applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml index \
                99e8e36..83f0b9d 100644
--- a/applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml
+++ b/applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml
@@ -30,8 +30,6 @@ Item {
     function popupEventSlot(shown) {
         if (shown) {
             view.forceActiveFocus();
-        } else {
-            view.currentIndex = -1;
         }
     }
 
@@ -110,12 +108,6 @@ Item {
         focus: true
         keyNavigationWraps: true
 
-        onCurrentIndexChanged: {
-            if (currentIndex != -1) {
-                highlightItem.opacity = 1.0;
-            }
-        }
-
         delegate: Item {
             id: listdelegate
             height: textMetric.paintedHeight * 2
@@ -158,11 +150,6 @@ Item {
 
                 onEntered: {
                     view.currentIndex = index;
-                    view.highlightItem.opacity = 1.0;
-                }
-
-                onExited: {
-                    view.highlightItem.opacity = 0;
                 }
             }
 


[prev in list] [next in list] [prev in thread] [next in thread]