[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kdepim-runtime/KDE/4.13] resources/pop3/wizard: rename pop3wizard.js to pop3wizard.es
From:       laurent Montel <montel () kde ! org>
Date:       2014-03-22 12:01:44
Message-ID: 4900153.fXnsopCUCd () linux-7fma
[Download RAW message or body]


It will good to test changes before to commit !

<anonymous>()@/opt/kde4/share/apps/akonadi/accountwizard/pop3/pop3wizard.es:61" 
Kross: "Error error=ReferenceError: Can't find variable: connect lineno=61 
trace=
<anonymous>()@/opt/kde4/share/apps/akonadi/accountwizard/pop3/pop3wizard.es:61" 


There was a reason why I didn't change it.
Please revert or fix it.



Le Saturday 22 March 2014 10:35:40 Pino Toscano a écrit :
> Git commit 78037dac8cf2fa6778f26281f3478955a07a9a02 by Pino Toscano.
> Committed on 22/03/2014 at 10:32.
> Pushed by pino into branch 'KDE/4.13'.
> 
> rename pop3wizard.js to pop3wizard.es
> 
> this matches what is done in other wizards
> 
> M  +1    -1    resources/pop3/wizard/CMakeLists.txt
> M  +1    -1    resources/pop3/wizard/Messages.sh
> M  +1    -1    resources/pop3/wizard/pop3wizard.desktop
> R  +0    -0    resources/pop3/wizard/pop3wizard.es [from:
> resources/pop3/wizard/pop3wizard.js - 100% similarity]
> 
> http://commits.kde.org/kdepim-runtime/78037dac8cf2fa6778f26281f3478955a07a9a
> 02
> 
> diff --git a/resources/pop3/wizard/CMakeLists.txt
> b/resources/pop3/wizard/CMakeLists.txt index fb49c4e..638e2b5 100644
> --- a/resources/pop3/wizard/CMakeLists.txt
> +++ b/resources/pop3/wizard/CMakeLists.txt
> @@ -1,2 +1,2 @@
> 
> -install ( FILES pop3wizard.desktop pop3wizard.js pop3wizard.ui DESTINATION
> ${DATA_INSTALL_DIR}/akonadi/accountwizard/pop3 ) +install ( FILES
> pop3wizard.desktop pop3wizard.es pop3wizard.ui DESTINATION
> ${DATA_INSTALL_DIR}/akonadi/accountwizard/pop3 ) diff --git
> a/resources/pop3/wizard/Messages.sh b/resources/pop3/wizard/Messages.sh
> index b68b930..2689f1f 100644
> --- a/resources/pop3/wizard/Messages.sh
> +++ b/resources/pop3/wizard/Messages.sh
> @@ -1,4 +1,4 @@
>  #! /usr/bin/env bash
>  $EXTRACTRC *.ui >> rc.cpp
>  $XGETTEXT *.cpp -o $podir/accountwizard_pop3.pot
> -$XGETTEXT -kqsTr *.js -j -o $podir/accountwizard_pop3.pot
> +$XGETTEXT -kqsTr *.es -j -o $podir/accountwizard_pop3.pot
> diff --git a/resources/pop3/wizard/pop3wizard.desktop
> b/resources/pop3/wizard/pop3wizard.desktop index c3eb880..10b81ab 100644
> --- a/resources/pop3/wizard/pop3wizard.desktop
> +++ b/resources/pop3/wizard/pop3wizard.desktop
> @@ -99,7 +99,7 @@ Comment[zh_TW]=Pop3 帳號
> 
>  [Wizard]
>  Type=message/rfc822
> -Script=pop3wizard.js
> +Script=pop3wizard.es
> 
>  [Translate]
>  Filename=accountwizard_pop3
> diff --git a/resources/pop3/wizard/pop3wizard.js
> b/resources/pop3/wizard/pop3wizard.es similarity index 100%
> rename from resources/pop3/wizard/pop3wizard.js
> rename to resources/pop3/wizard/pop3wizard.es

-- 
Laurent Montel | laurent.montel@kdab.com | KDE/Qt Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company
Tel. France +33 (0)4 90 84 08 53, Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-independent software solutions

[prev in list] [next in list] [prev in thread] [next in thread]