[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [oxygen-gtk/gtk3] src: Cleanup sources. Do not implement private methods (instead of using assert), 
From:       Hugo Pereira Da Costa <hugo () oxygen-icons ! org>
Date:       2014-02-24 13:44:58
Message-ID: E1WHvq6-0002gC-I5 () scm ! kde ! org
[Download RAW message or body]

Git commit a7214b9919126ac87c5f491c34406e6718285c29 by Hugo Pereira Da Costa.
Committed on 24/02/2014 at 13:44.
Pushed by hpereiradacosta into branch 'gtk3'.

Cleanup sources. Do not implement private methods (instead of using assert), to get a compile-time error
instead of run-time;
added some copy constructor as non-implemented private methods.

M  +3    -18   src/oxygencairocontext.h
M  +3    -0    src/oxygencairoregion.h
M  +1    -5    src/oxygencairosurface.h

http://commits.kde.org/oxygen-gtk/a7214b9919126ac87c5f491c34406e6718285c29

diff --git a/src/oxygencairocontext.h b/src/oxygencairocontext.h
index d80cbfe..4f8f6e6 100644
--- a/src/oxygencairocontext.h
+++ b/src/oxygencairocontext.h
@@ -56,10 +56,6 @@ namespace Oxygen
             operator cairo_t* (void) const
             { return _cr; }
 
-            //! context accessor
-            cairo_t* cr( void ) const
-            { return _cr; }
-
             //! set clipping
             void setClipping( GdkRectangle* ) const;
 
@@ -71,24 +67,13 @@ namespace Oxygen
             { assert( false ); }
 
             //! copy constructor is private
-            Context( const Context& other ):
-                _cr( 0L )
-            { assert( false ); }
+            Context( const Context& );
 
             //! equal to operator is private
-            Context& operator = (const Context& other )
-            {
-                _cr = other._cr;
-                assert( false );
-                return *this;
-            }
+            Context& operator = (const Context& );
 
             //! equal to operator is private
-            Context& operator = (cairo_t* other )
-            {
-                assert( false );
-                return *this;
-            }
+            Context& operator = (cairo_t* );
 
             //! cairo contect
             cairo_t* _cr;
diff --git a/src/oxygencairoregion.h b/src/oxygencairoregion.h
index 2a5fae4..6aca564 100644
--- a/src/oxygencairoregion.h
+++ b/src/oxygencairoregion.h
@@ -90,6 +90,9 @@ namespace Oxygen
 
             private:
 
+            //! equal to operator is private
+            Region& operator = (cairo_region_t* );
+
             //! region
             cairo_region_t* _region;
 
diff --git a/src/oxygencairosurface.h b/src/oxygencairosurface.h
index b494fab..1c76137 100644
--- a/src/oxygencairosurface.h
+++ b/src/oxygencairosurface.h
@@ -95,11 +95,7 @@ namespace Oxygen
             private:
 
             //! equal to operator is private
-            Surface& operator = (cairo_surface_t* other )
-            {
-                assert( false );
-                return *this;
-            }
+            Surface& operator = (cairo_surface_t* );
 
             //! surface
             cairo_surface_t* _surface;
[prev in list] [next in list] [prev in thread] [next in thread]