[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kate/frameworks] /: Fix build
From:       Alex Merry <kde () randomguy3 ! me ! uk>
Date:       2014-02-19 12:24:24
Message-ID: E1WG6CO-0000R7-EW () scm ! kde ! org
[Download RAW message or body]

Git commit ceb0c083ba43092a0c4e9fe8b82a921b832e98e9 by Alex Merry.
Committed on 19/02/2014 at 12:22.
Pushed by alexmerry into branch 'frameworks'.

Fix build

A couple of places in the CMakeLists.txt files seem to assume that
linking library A against library B will cause anything linked to A to
inherit the link to B.  This is only true of PUBLIC (or INTERFACE)
links.

M  +1    -0    addons/filetree/CMakeLists.txt
M  +1    -0    kate/src/CMakeLists.txt

http://commits.kde.org/kate/ceb0c083ba43092a0c4e9fe8b82a921b832e98e9

diff --git a/addons/filetree/CMakeLists.txt b/addons/filetree/CMakeLists.txt
index b6ba4b8..ed88aae 100644
--- a/addons/filetree/CMakeLists.txt
+++ b/addons/filetree/CMakeLists.txt
@@ -9,6 +9,7 @@ include_directories( ${CMAKE_CURRENT_BINARY_DIR} )
 add_library (katefiletree STATIC  ${katefiletree_PART_SRCS})
 =

 target_link_libraries(katefiletree
+PUBLIC
   KF5::TextEditor
   KF5::I18n
   KF5::GuiAddons
diff --git a/kate/src/CMakeLists.txt b/kate/src/CMakeLists.txt
index f1471fb..5c3d00a 100644
--- a/kate/src/CMakeLists.txt
+++ b/kate/src/CMakeLists.txt
@@ -44,6 +44,7 @@ qt5_wrap_ui(KATE_APPLICATION_SRCS
 # create kde init executable
 kf5_add_kdeinit_executable(kate ${KATE_APPLICATION_SRCS})
 target_link_libraries(kdeinit_kate
+PUBLIC
     KF5::TextEditor
     KF5::I18n
     KF5::KIOFileWidgets
[prev in list] [next in list] [prev in thread] [next in thread]