[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [cantor/KDE/4.12] src/backends/sage: fix reversed comparison when determining if legacy mode is need
From:       Alexander Rieder <alexanderrieder () gmail ! com>
Date:       2014-02-01 18:54:56
Message-ID: E1W9fiS-0007Go-Nz () scm ! kde ! org
[Download RAW message or body]

Git commit f6f01298a5d86fb7dfe1d829df2e4c4cc35b4c44 by Alexander Rieder.
Committed on 01/02/2014 at 18:50.
Pushed by arieder into branch 'KDE/4.12'.

fix reversed comparison when determining if legacy mode is needed
for tab completion in sage backend.
Thanks to Yichao Zhou for spotting this.

CCMAIL: broken.zhou@gmail.com
BUG: 330632

M  +1    -1    src/backends/sage/sagecompletionobject.cpp

http://commits.kde.org/cantor/f6f01298a5d86fb7dfe1d829df2e4c4cc35b4c44

diff --git a/src/backends/sage/sagecompletionobject.cpp b/src/backends/sage/sagecompletionobject.cpp
index 83e11ee..259b9ff 100644
--- a/src/backends/sage/sagecompletionobject.cpp
+++ b/src/backends/sage/sagecompletionobject.cpp
@@ -63,7 +63,7 @@ void SageCompletionObject::fetchCompletions()
 void SageCompletionObject::extractCompletions()
 {
   SageSession* s=qobject_cast<SageSession*>(session());
-  if(s&&s->sageVersion()>SageSession::VersionInfo(5, 7))
+  if(s&&s->sageVersion()<SageSession::VersionInfo(5, 7))
     extractCompletionsLegacy();
   else
     extractCompletionsNew();
[prev in list] [next in list] [prev in thread] [next in thread]