[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kbibtex] src/program/docklets: Minor optimization omitting creating a variable
From:       Thomas Fischer <fischer () unix-ag ! uni-kl ! de>
Date:       2014-01-31 21:40:45
Message-ID: E1W9LpN-0000er-IR () scm ! kde ! org
[Download RAW message or body]

Git commit 31dcb511e29fce9732ab34969460e3ac04f1156e by Thomas Fischer.
Committed on 28/01/2014 at 19:15.
Pushed by thomasfischer into branch 'master'.

Minor optimization omitting creating a variable

M  +1    -2    src/program/docklets/valuelist.cpp

http://commits.kde.org/kbibtex/31dcb511e29fce9732ab34969460e3ac04f1156e

diff --git a/src/program/docklets/valuelist.cpp b/src/program/docklets/valuelist.cpp
index 10895aa..3cc38bc 100644
--- a/src/program/docklets/valuelist.cpp
+++ b/src/program/docklets/valuelist.cpp
@@ -151,8 +151,7 @@ public:
     }
 
     void update() {
-        QVariant var = comboboxFieldNames->itemData(comboboxFieldNames->currentIndex());
-        QString text = var.toString();
+        QString text = comboboxFieldNames->itemData(comboboxFieldNames->currentIndex()).toString();
         if (text.isEmpty()) text = comboboxFieldNames->currentText();
 
         delegate->setFieldName(text);

[prev in list] [next in list] [prev in thread] [next in thread]