[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [marble] src/lib/marble: legend: simplify input parameters for checkbox
From:       Thibaut Gridel <tgridel () free ! fr>
Date:       2014-01-04 21:43:03
Message-ID: E1VzYzn-0003y0-1L () scm ! kde ! org
[Download RAW message or body]

Git commit 485343526d25c11214776aef48240b8647856381 by Thibaut Gridel.
Committed on 04/01/2014 at 21:11.
Pushed by tgridel into branch 'master'.

legend: simplify input parameters for checkbox

M  +3    -3    src/lib/marble/MarbleLegendBrowser.cpp

http://commits.kde.org/marble/485343526d25c11214776aef48240b8647856381

diff --git a/src/lib/marble/MarbleLegendBrowser.cpp \
b/src/lib/marble/MarbleLegendBrowser.cpp index 8496960..0f4f684 100644
--- a/src/lib/marble/MarbleLegendBrowser.cpp
+++ b/src/lib/marble/MarbleLegendBrowser.cpp
@@ -258,7 +258,7 @@ void MarbleLegendBrowser::reverseSupportCheckboxes(QString &html)
 
     const QString repair = ""
             "<input type=\"checkbox\" "
-            "onchange=\"Marble.setCheckedProperty(this.value, this.checked);\" " + \
checked + " name=\"cities\" value=\"cities\" />"; +            \
"onchange=\"Marble.setCheckedProperty(this.name, this.checked);\" " + checked + " \
name=\"cities\"/>";  
     html.replace(old, repair);
 }
@@ -309,7 +309,7 @@ QString MarbleLegendBrowser::generateSectionsHtml()
                 checkBoxString = ""
                         "<label class=\"section-head\">"
                         "<input type=\"checkbox\" "
-                        "onchange=\"Marble.setCheckedProperty(this.value, \
this.checked);\" "+checked+" value=\"" + section->connectTo() + "\" name=\"" + \
section->connectTo() + "\" /><span>" +                        \
"onchange=\"Marble.setCheckedProperty(this.name, this.checked);\" "+checked+" \
name=\"" + section->connectTo() + "\" /><span>"  + section->heading() +
                         "</span></label>";
 
@@ -359,7 +359,7 @@ QString MarbleLegendBrowser::generateSectionsHtml()
 
 void MarbleLegendBrowser::setCheckedProperty( const QString& name, bool checked )
 {
-    QWebElement box = \
page()->mainFrame()->findFirstElement("input[value="+name+']'); +    QWebElement box \
= page()->mainFrame()->findFirstElement("input[name="+name+']');  if (!box.isNull()) \
{  if (checked != d->m_checkBoxMap[name]) {
             d->m_checkBoxMap[name] = checked;


[prev in list] [next in list] [prev in thread] [next in thread]