[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kate/frameworks] part/buffer: filter device doesn't like truncate
From:       Michal Humpula <michal.humpula () seznam ! cz>
Date:       2013-12-31 19:08:46
Message-ID: 5070367.t2PbK2siUP () amonsul
[Download RAW message or body]

That is a little bit odd. That way you can only used it only on new file, no?

Cheers
Michal

On Tuesday 31 of December 2013 19:59:55 Christoph Cullmann wrote:
> It asserts that open mode is write only only, which is ok imho.
> 
> Am 31.12.2013 19:21 schrieb Dominik Haumann <dhaumann@kde.org>:
> > On Tuesday, December 31, 2013 02:04:03 PM Christoph Cullmann wrote:
> > > Git commit 84ed5e973ad22936c2b5813b9421f859002d33e3 by Christoph
> > > Cullmann.
> > > Committed on 31/12/2013 at 13:53.
> > > Pushed by cullmann into branch 'frameworks'.
> > > 
> > > filter device doesn't like truncate
> > 
> > In what sense?
> > 
> > Maybe this is of relevance for David?
> > 
> > CC: David
> > 
> > Greetings,
> > Dominik
> > 
> > > M  +1    -1    part/buffer/katetextbuffer.cpp
> > > 
> > > http://commits.kde.org/kate/84ed5e973ad22936c2b5813b9421f859002d33e3
> > > 
> > > diff --git a/part/buffer/katetextbuffer.cpp
> > > b/part/buffer/katetextbuffer.cpp index c63c1cb..05acfeb 100644
> > > --- a/part/buffer/katetextbuffer.cpp
> > > +++ b/part/buffer/katetextbuffer.cpp
> > > @@ -735,7 +735,7 @@ bool TextBuffer::save (const QString &filename)
> > >
> > >    /**
> > >     * try to open, if new file
> > >     */
> > >
> > > -  if (!file.open (QIODevice::WriteOnly | QIODevice::Truncate))
> > > +  if (!file.open (QIODevice::WriteOnly))
> > >
> > >      return false;
> > >
> > >    /**

[prev in list] [next in list] [prev in thread] [next in thread]