[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kate/frameworks] /: cleanup the Editor instance mess, just one global instance, cleanup on QCor
From:       Christoph Cullmann <cullmann () absint ! com>
Date:       2013-12-31 18:52:18
Message-ID: 20131231185218.C5C614C67924 () mail ! absint ! com
[Download RAW message or body]

It should work without any such hacks now. Should have never be needed.

Am 31.12.2013 19:15 schrieb Dominik Haumann <dhaumann@kde.org>:
>
> On Tuesday, December 31, 2013 08:59:01 AM Christoph Cullmann wrote: 
> > Git commit 56e9d931f92dffbaa5aa603689fbebdff6a3f442 by Christoph Cullmann. 
> > Committed on 31/12/2013 at 08:48. 
> > Pushed by cullmann into branch 'frameworks'. 
> > 
> > cleanup the Editor instance mess, just one global instance, cleanup on 
> > QCoreApplication exit, like we do since long in 4.x series to avoid any 
> > problems, but now really just do that, no nifty not needed ref counting 
> > 
> > M  +1    -1    kate/app/katedocmanager.cpp 
> > M  +1    -2    ktexteditor/include/CMakeLists.txt 
> > M  +15   -11   ktexteditor/include/ktexteditor/editor.h 
> > D  +0    -126  ktexteditor/include/ktexteditor/factory.h 
> > M  +32   -49   ktexteditor/src/ktexteditor.cpp 
> > M  +1    -1    kwrite/kwriteapp.cpp 
> > M  +1    -1    kwrite/kwritemain.cpp 
> > M  +0    -2    part/TODO 
> > M  +0    -5    part/document/katebuffer.cpp 
> > M  +1    -1    part/snippet/editrepository.cpp 
> > M  +8    -18   part/utils/katefactory.cpp 
> > M  +11   -6    part/utils/kateglobal.cpp 
> > M  +0    -15   part/utils/kateglobal.h 
> > M  +0    -2    tests/bug286887.cpp 
> > M  +0    -3    tests/bug313759.cpp 
> > M  +0    -2    tests/bug313769.cpp 
> > M  +0    -3    tests/bug317111.cpp 
> > M  +1    -1    tests/completion_test.cpp 
> > M  +0    -2    tests/katefoldingtest.cpp 
> > M  +0    -2    tests/kte_documentcursor.cpp 
> > M  +0    -2    tests/messagetest.cpp 
> > M  +0    -2    tests/modificationsystem_test.cpp 
> > M  +0    -2    tests/script_test_base.cpp 
> > M  +1    -1    tests/wordcompletiontest.cpp 
>
> If I remember correctly, the incRef() and decRef() calls were needed in the 
> test cases in initTestCase() to make sure KateGlobal is instanciated 
> correctly. 
>
> Is this still guaranteed now? If not, one should call KateGlobal::self() or 
> Editor::instance() once in the respective test cases where you remove this. 
>
> Greetings, 
> Dominik 

[prev in list] [next in list] [prev in thread] [next in thread]