[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kate/frameworks] ktexteditor: more application API
From:       Dominik Haumann <dhaumann () kde ! org>
Date:       2013-12-31 18:14:07
Message-ID: 7935767.4CDuUJSyZ9 () palpatine ! rt ! e-technik ! tu-darmstadt ! de
[Download RAW message or body]

On Tuesday, December 31, 2013 08:19:34 AM Christoph Cullmann wrote:
> Git commit 9db7fd4ccb436928e6b3369bce203ad48b08b817 by Christoph Cullmann.
> Committed on 31/12/2013 at 08:08.
> Pushed by cullmann into branch 'frameworks'.
> 
> more application API
> 
> M  +74   -1    ktexteditor/include/ktexteditor/application.h
> M  +100  -0    ktexteditor/src/application.cpp
> 
> http://commits.kde.org/kate/9db7fd4ccb436928e6b3369bce203ad48b08b817
> 
> diff --git a/ktexteditor/include/ktexteditor/application.h
> b/ktexteditor/include/ktexteditor/application.h index e0d6780..0f4d4b1
> 100644
> --- a/ktexteditor/include/ktexteditor/application.h
> +++ b/ktexteditor/include/ktexteditor/application.h
> @@ -79,6 +80,78 @@ class KTEXTEDITOR_EXPORT Application : public QObject
> +
> +      /**
> +       * This signal is emitted before a \p document which should be closed
> is deleted +       * The document is still accessible and usable, but it
> will be deleted +       * after this signal was send.
> +       *
> +       * @param document document that will be deleted
> +       */
> +      void documentWillBeDeleted (KTextEditor::Document *document);

Can you rename to
  void aboutToDeleteDocument (KTextEditor::Document *document);

? Would be much more consistent Qt-style API.

Greetings,
Dominik
[prev in list] [next in list] [prev in thread] [next in thread]