[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kdevelop/4.6] app/welcomepage: WelcomePage: Fix height of left sidebar
From:       Kevin Funk <kevin () kfunk ! org>
Date:       2013-12-28 18:50:29
Message-ID: E1Vwyxx-0006Wl-Du () scm ! kde ! org
[Download RAW message or body]

Git commit 2bd0a62a91c50d89cbce85ad45f3397593bb9a4c by Kevin Funk.
Committed on 28/12/2013 at 18:39.
Pushed by kfunk into branch '4.6'.

WelcomePage: Fix height of left sidebar

BUG: 329300
FIXED-IN: 4.6.1

M  +4    -5    app/welcomepage/StandardBackground.qml
M  +1    -6    app/welcomepage/code.qml

http://commits.kde.org/kdevelop/2bd0a62a91c50d89cbce85ad45f3397593bb9a4c

diff --git a/app/welcomepage/StandardBackground.qml b/app/welcomepage/StandardBackground.qml
index 503d875..630ba8e 100644
--- a/app/welcomepage/StandardBackground.qml
+++ b/app/welcomepage/StandardBackground.qml
@@ -39,13 +39,12 @@ Rectangle
             margins: parent.margins
         }
         width: 256
-        height: 100
+        height: toolsLoader.height + 2*20
         Loader {
+            id: toolsLoader
+
+            anchors.centerIn: parent
             sourceComponent: tools
-            anchors {
-                fill: parent
-                margins: 20
-            }
         }
     }
     
diff --git a/app/welcomepage/code.qml b/app/welcomepage/code.qml
index 5cb4649..af1944b 100644
--- a/app/welcomepage/code.qml
+++ b/app/welcomepage/code.qml
@@ -32,17 +32,12 @@ StandardBackground {
 
     tools: ButtonColumn {
         spacing: 10
-        Link {
-            anchors.margins: 20
-            width: parent.width
 
+        Link {
             text: i18n("Starting")
             onClicked: root.state = "starting"
         }
         Link {
-            anchors.margins: 20
-            width: parent.width
-
             text: i18n("Learn KDevelop!")
             onClicked: root.state = "learning"
         }

[prev in list] [next in list] [prev in thread] [next in thread]