[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kdevplatform] /: remove FOREACH_ARRAY, just use Qt's foreach and be done with it...
From:       Kevin Funk <krf () gmx ! de>
Date:       2013-12-09 8:22:39
Message-ID: 1858371.P855uHMKDs () kerberos
[Download RAW message or body]

Am Samstag, 7. Dezember 2013, 17:39:23 schrieb Milian Wolff:
> Git commit cec794b517f1415c696735ddb0144118e9996c7b by Milian Wolff.
> Committed on 07/12/2013 at 17:39.
> Pushed by mwolff into branch 'master'.
> 
> remove FOREACH_ARRAY, just use Qt's foreach and be done with it...
> 
> M  +2    -2    language/duchain/declaration.cpp
> M  +1    -1    language/duchain/declarationid.cpp
> M  +1    -1    language/duchain/duchain.cpp
> M  +1    -1    language/duchain/duchainutils.cpp
> M  +10   -10   language/duchain/ducontext.cpp
> M  +2    -2    language/duchain/functiondefinition.cpp
> M  +4    -4    language/duchain/topducontext.cpp
> M  +0    -7    util/kdevvarlengtharray.h
> 
> http://commits.kde.org/kdevplatform/cec794b517f1415c696735ddb0144118e9996c7b
> 
> (snip)

Hey,

the purpose of FOREACH_ARRAY was to not create a copy of QVarLengthArray 
instances. Doesn't that have any performance impacts?

Note that QVarLengthArray is *not* implicitly shared, hence this will cause a 
deep-copy when Qt's foreach is used.

Greets

-- 
Kevin Funk
[prev in list] [next in list] [prev in thread] [next in thread]