[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kdev-php] completion: Improve Code Completion when executing ImplementationItem
From:       Niko Sams <niko.sams () gmail ! com>
Date:       2013-11-20 19:22:49
Message-ID: E1VjDMP-0007qO-It () scm ! kde ! org
[Download RAW message or body]

Git commit 16e38b36da2c5630f743ae8d49ed5edf4f689960 by Niko Sams.
Committed on 20/11/2013 at 19:22.
Pushed by nsams into branch 'master'.

Improve Code Completion when executing ImplementationItem

Don't add call to parent if parent is an abstract method.

M  +1    -1    completion/implementationitem.cpp

http://commits.kde.org/kdev-php/16e38b36da2c5630f743ae8d49ed5edf4f689960

diff --git a/completion/implementationitem.cpp b/completion/implementationitem.cpp
index 441d116..cf6838c 100644
--- a/completion/implementationitem.cpp
+++ b/completion/implementationitem.cpp
@@ -240,7 +240,7 @@ void ImplementationItem::execute(KTextEditor::Document* document, \
const KTextEdi  }
 
         replText += QString("\n%1{\n%1    ").arg(indendation);
-        if (isInterface) {
+        if (isInterface || m_type == ImplementationItem::Implement) {
         } else if (!isConstructorOrDestructor && !voidReturnType) {
             replText += QString("$ret = parent::%2%3;\n%1    return \
$ret;").arg(indendation).arg(functionName).arg(arguments);  } else {


[prev in list] [next in list] [prev in thread] [next in thread]