[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kajongg/sid] src: pylint cleanups
From:       Wolfgang Rohdewald <wolfgang () rohdewald ! de>
Date:       2013-10-31 21:21:05
Message-ID: E1Vbzft-0002lj-1a () scm ! kde ! org
[Download RAW message or body]

Git commit 7b87f2c670506d3d5bb75d95b625b9dcc0efb2ca by Wolfgang Rohdewald.
Committed on 29/10/2013 at 10:20.
Pushed by wrohdewald into branch 'sid'.

pylint cleanups

M  +0    -1    src/client.py
M  +1    -1    src/player.py
M  +0    -1    src/playfield.py
M  +0    -1    src/rulecode.py
M  +1    -1    src/scoring.py
M  +2    -2    src/tile.py
M  +1    -1    src/uitile.py

http://commits.kde.org/kajongg/7b87f2c670506d3d5bb75d95b625b9dcc0efb2ca

diff --git a/src/client.py b/src/client.py
index b7dd18c..be16c83 100644
--- a/src/client.py
+++ b/src/client.py
@@ -31,7 +31,6 @@ from util import logDebug, logException, logWarning, Duration, m18nc, checkMemor
 from message import Message
 from common import Internal, Debug, Options
 from rule import Ruleset
-from meld import meldsContent
 from game import PlayingGame
 from query import Transaction, Query
 from move import Move
diff --git a/src/player.py b/src/player.py
index 6a0ca29..3deab5d 100644
--- a/src/player.py
+++ b/src/player.py
@@ -391,7 +391,7 @@ class Player(object):
         parts.extend(str(x) for x in self._bonusTiles)
         return ' '.join(parts)
 
-    def sortRulesByX(self, rules):
+    def sortRulesByX(self, rules): # pylint: disable=no-self-use
         """if this game has a GUI, sort rules by GUI order"""
         return rules
 
diff --git a/src/playfield.py b/src/playfield.py
index a3b77c5..de76297 100644
--- a/src/playfield.py
+++ b/src/playfield.py
@@ -70,7 +70,6 @@ try:
     from games import Games
     from statesaver import StateSaver
     from hand import Hand
-    from tile import Tile
     from uitile import UITile
     from meld import Meld, CONCEALED
     from scoring import ExplainView, ScoringDialog, ScoreTable
diff --git a/src/rulecode.py b/src/rulecode.py
index d50f2d7..8e8206b 100644
--- a/src/rulecode.py
+++ b/src/rulecode.py
@@ -26,7 +26,6 @@ from meld import Meld, CONCEALED, EXPOSED, CLAIMEDKONG, REST, elementKey
 from common import IntDict, WINDS
 from message import Message
 from query import Query
-from util import logDebug
 
 class Function(object):
     """Parent for all Function classes. We need to implement
diff --git a/src/scoring.py b/src/scoring.py
index db7abfd..aab0e00 100644
--- a/src/scoring.py
+++ b/src/scoring.py
@@ -1158,7 +1158,7 @@ class ScoringDialog(QWidget):
         self.computeScores()
         self.validate()
         for player in self.game.players:
-                self.game.wall.decoratePlayer(player)
+            self.game.wall.decoratePlayer(player)
         Internal.field.updateGUI()
 
     def validate(self):
diff --git a/src/tile.py b/src/tile.py
index 0bb1226..1ba4271 100644
--- a/src/tile.py
+++ b/src/tile.py
@@ -70,10 +70,10 @@ class Tile(bytes):
             return self.lower()
 
     def __delitem__(self, index):
-        raise NotImplementedError
+        assert False
 
     def __setitem__(self, index):
-        raise NotImplementedError
+        assert False
 
     def __repr__(self):
         """default representation"""
diff --git a/src/uitile.py b/src/uitile.py
index c26a46c..370341a 100644
--- a/src/uitile.py
+++ b/src/uitile.py
@@ -21,7 +21,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
 from PyQt4.QtCore import Qt, QString, QRectF, QPointF, QSizeF, QSize, pyqtProperty
 from PyQt4.QtGui import QGraphicsObject, QGraphicsItem, QPixmap, QPainter
 from PyQt4.QtGui import QColor
-from util import logException, stack, logDebug, m18nc
+from util import logException, stack, logDebug
 from common import LIGHTSOURCES, ZValues, Internal, Preferences, Debug, isAlive
 
 from tile import Tile

[prev in list] [next in list] [prev in thread] [next in thread]