[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kdelibs/frameworks] tier1/kwidgetsaddons/src: Introduce KMessageBoxNotifyInterface
From:       David Faure <faure () kde ! org>
Date:       2013-10-22 12:27:02
Message-ID: 5511537.CuIQIUta5P () asterix
[Download RAW message or body]

On Tuesday 22 October 2013 13:14:06 Aurélien Gâteau wrote:
> Using QSharedPointer is not a problem

I don't understand the use of QSharedPointer here. That's a reference count. 
But what are we counting? This class is the only one which can see the 
QSharedPointer, so the refcount is always 1, isn't it?

> but I am not sure we want to use 
> Q_GLOBAL_STATIC for the default implementations: isn't this going to create
> a  situation where the default implementations are deleted at exit but not
> the implementations provided by the plugin?

Yep. How is that a problem? The plugin deletes its own instances.
(see 
staging/frameworkintegration/src/integrationplugin/frameworkintegrationplugin.h
they are member vars of the plugin)

-- 
David Faure, faure@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5

[prev in list] [next in list] [prev in thread] [next in thread]