[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kde-workspace/frameworks-scratch] kwin: create a variable and not a function declaration
From:       Martin Graesslin <mgraesslin () kde ! org>
Date:       2013-09-13 15:10:54
Message-ID: 72589670.BBGsgBqKH2 () martin-thinkpad
[Download RAW message or body]


On Friday 13 September 2013 14:54:07 Alex Richardson wrote:
> Git commit 4369a746d5a6b2386cecce1a3e1104954e7c5754 by Alex 
Richardson.
> Committed on 13/09/2013 at 14:51.
> Pushed by arichardson into branch 'frameworks-scratch'.
> 
> create a variable and not a function declaration
> 
> found with the clang -Wvexing-parse warning
nice catch! I think that would also make sense in 4.11 branch. Though it needs 
testing as the behavior now significantly changed.
> 
> M  +1    -1    kwin/scene.cpp
> 
> http://commits.kde.org/kde-workspace/4369a746d5a6b2386cecce1a3e1104954e7c575
> 4
> 
> diff --git a/kwin/scene.cpp b/kwin/scene.cpp
> index b343829..a39e5a3 100644
> --- a/kwin/scene.cpp
> +++ b/kwin/scene.cpp
> @@ -806,7 +806,7 @@ void WindowPixmap::create()
>      if (isValid()) {
>          return;
>      }
> -    XServerGrabber grabber();
> +    XServerGrabber grabber;
>      xcb_pixmap_t pix = xcb_generate_id(connection());
>      xcb_void_cookie_t namePixmapCookie =
> xcb_composite_name_window_pixmap_checked(connection(),
> toplevel()->frameId(), pix); Xcb::WindowAttributes
> windowAttributes(toplevel()->frameId());

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]