[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [amarok] /: Fix long-standing issue with not finding plugins after upgrade.
From:       Matěj Laitl <matej () laitl ! cz>
Date:       2013-09-12 16:29:12
Message-ID: 2799338.3PUz9CJvVE () edgy
[Download RAW message or body]

Heya,

On 12. 9. 2013 Mark Kretschmann wrote:
> +    KProcess::execute( KStandardDirs::findExe( "kbuildsycoca4" ),
> QStringList( "--noincremental" ) ); +
> +    // Wait a bit until ksycoca has fully updated
> +    for( int i = 0; i < 3; i++ ) {
> +        sleep( 1 );
> +        QApplication::processEvents();
> +    }

Hmm, just wait 3 seconds in all cases, this looks like a magic constant to me. 
Cannot we just use KProcess api to continue at exact time kbuildsycoca 
finishes? (and to report whether it exits with a failure and/or its error 
messages?)

	Matěj
[prev in list] [next in list] [prev in thread] [next in thread]