[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kdesvn] src/svnqt: BUG 324158
From:       Rajko Albrecht <ral () alwins-world ! de>
Date:       2013-09-02 18:56:23
Message-ID: E1VGZIV-00047D-2i () scm ! kde ! org
[Download RAW message or body]

Git commit f2df8b86ecdaad607ad9418bc808115367e69c8a by Rajko Albrecht.
Committed on 02/09/2013 at 18:55.
Pushed by rajkoalbrecht into branch 'master'.

BUG 324158

Kdesvn will not crash with an assert when users have pathnames with @

But subversion will never display any content of such files or folder, you can test \
it with the command line.

(Tested against subversion 1.7.x)

M  +7    -1    src/svnqt/path.cpp

http://commits.kde.org/kdesvn/f2df8b86ecdaad607ad9418bc808115367e69c8a

diff --git a/src/svnqt/path.cpp b/src/svnqt/path.cpp
index 57b4cfb..3f36dc1 100644
--- a/src/svnqt/path.cpp
+++ b/src/svnqt/path.cpp
@@ -91,13 +91,19 @@ namespace svn
       }
 
       m_path = QString::FROMUTF8(int_path);
-      if (Url::isValid(m_path) && m_path.indexOf("@")!=-1 ) {
+      /* the following block is a problem and thats why commented out: since a while \
subversion raises +       * an assert because of wrong url if replacing the @ sign \
with entity and kdesvn dies.  +       * So using the scheme on ubuntu that it just \
don't display the content of such a folder/file. +       */
+      /*
+       if (Url::isValid(m_path) && m_path.indexOf("@")!=-1 ) {
         /// @todo make sure that "@" is never used as revision parameter
         QUrl uri = m_path;
         m_path = uri.path();
         m_path.replace('@',"%40");
         m_path = uri.scheme()+"://"+uri.authority()+m_path;
       }
+      */
         
         while (m_path.endsWith('/')) {
             m_path.chop(1);


[prev in list] [next in list] [prev in thread] [next in thread]